Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795055773; b=p3DcxK6rpwqyVuuEj1k9lcKyKg5bwmzwynfqEIMdgVqKpnri53CWEz+3N/JgiDGHPVNL ez25Wtp6tNwQO8hlJtCBQ38Wm5aig3MYdSVgXOuqJf5j/cf3ffMIqCyP1Qs9ATFZg4dVx tVSQm+N55G5T2XSINFOwjlNx/bERQPuCsRTrADQaf1Lu6+u/edYFnWMwEKeGwFqX2wWx/ 3mRUUlglUuNVPYKxCzplPTWz1Rb7JrwyP6tPToyWMsJHfK2K5kVT8ayOu03/jPpA8frXk /W+8CCNucUR2fD+6ZC++niMs1HOZWZoHhHm+4tF2I5ktDZG+kvLtJawR7N7Vaxs2gbA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795055773; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Hb+OSXcv6/J+jPAkGDKcPUtrDSVCDrV59cuAqR1OiR4=; b=XvrFlp1c2UcLlPCx8yLvEoTCyxa7CyzO3hX7synlR/rcR3a06oXH0uIbE4W3tuOxPxS8 icVytEFFGvGvj2rcgMw9koI9M6aID2GRiymFUo2rEQHhk1XzwGpxcHQD7Uog6dLXJIUN7 rXPWTJfgvIFRkWl7pXMGk6UHLciKWu3LScTMCLrUIsGumOvcEfsOYt1FeUUK1MyHnuWP8 xLAUc3BbOE2xFDQkmtYbLj26e1g+rlRpGSlNXRpcocFEqwKxeciYBdEC1+JR2Ek4Uoo3Z vTNI2Azyx6P/24ZY8DT2JvLTs+5LREdYXBQXAD6DXNkS37vXy/SfhmQiuMiEd1mropQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=tSmgDCER; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1080606A332; Thu, 19 Nov 2026 02:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=tSmgDCER Received: by smtp.kernel.org (Postfix) with ESMTPSA id F36D61F000C5; Thu, 19 Nov 2026 02:36:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795055773; bh=Hb+OSXcv6/J+jPAkGDKcPUtrDSVCDrV59cuAqR1OiR4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tSmgDCERvANapjCvEfbpRVD2EfKdRoFqk3MlztfOEJIgdmwP++7ivawdczbZoZx4g AH+8tAhxSoXLNQCtZDTUMXvCpLSxNSLAyvWrMbc6ty+ZKuBnUxrf4sgZGSnFdI200H mYqBAK7pxeSZt2iM7wIbfYuV6C9AL+Nbi1aIzbvU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+619e27617b2abe6b9b72@syzkaller.appspotmail.com, Yang Xiuwei , "Denis Efremov (Oracle)" , Sasha Levin Subject: [PATCH 5.15 1751/2214] floppy: avoid NULL deref in reset_interrupt when cont is cleared Date: Wed, 18 Nov 2026 15:57:07 +0100 Message-ID: <20261118150121.632757746@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Xiuwei [ Upstream commit 7c82781039c03a3e47b70d3259f336adbb9d2692 ] reset_fdc() arms do_floppy = reset_interrupt; the IRQ handler then queues that function via schedule_bh(). If unlock_fdc() or do_wakeup() clears cont before the work runs, reset_interrupt() dereferences a NULL cont and oopses. Example crash excerpt: [ 1070.468148] status=80 [ 1070.468152] fdc_busy=1 [ 1070.468158] cont= (null) [ 1070.468161] current_req= (null) [ 1070.468162] command_status=-1 [ 1070.468163] [ 1070.557051] floppy0: floppy timeout called [ 1070.557053] no cont in shutdown! [ 1070.557056] floppy0: floppy_shutdown: timeout handler died. [ 1074.419509] floppy0: FDC access conflict! [ 1074.419782] BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 [ 1074.421969] PGD 0 P4D 0 [ 1074.422320] Oops: 0000 [#1] SMP NOPTI [ 1074.422648] CPU: 10 PID: 3269 Comm: kworker/u256:4 Kdump: loaded [ 1074.423830] Hardware name: inspur Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 1074.424284] Workqueue: floppy floppy_work_workfn [floppy] [ 1074.424757] RIP: 0010:reset_interrupt+0x3a/0xa0 [floppy] The same NULL deref has also been reported by syzbot on upstream. Return early if cont is already NULL after result(). The hardware reset has completed; result() still drains the FDC. A later request can lock the FDC and reset again. This is a defensive fix for stale work, not a rewrite of the floppy continuation state machine. Reported-by: syzbot+619e27617b2abe6b9b72@syzkaller.appspotmail.com Link: https://lore.kernel.org/linux-block/00000000000093c4d105f9aa34d6@google.com/ Link: https://lists.openwall.net/linux-kernel/2021/10/27/56 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Yang Xiuwei Link: https://patch.msgid.link/20260723073512.11120-1-yangxiuwei@kylinos.cn Signed-off-by: Denis Efremov (Oracle) Signed-off-by: Sasha Levin --- drivers/block/floppy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index d89469acf919d..ed7449861e94f 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -1785,6 +1785,9 @@ static void reset_interrupt(void) { debugt(__func__, ""); result(current_fdc); /* get the status ready for set_fdc */ + /* Stale work: unlock_fdc()/do_wakeup() may have cleared cont. */ + if (!cont) + return; if (fdc_state[current_fdc].reset) { pr_info("reset set in interrupt, calling %ps\n", cont->error); cont->error(); /* a reset just after a reset. BAD! */ -- 2.53.0