Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056096; b=TaSu5vBu88deA8rSGCAfgT3cvtlRSadYdshaApMRUTXFGIkzPEXB88dh6/wyXxYGz64N 7JEqCyY/p8AXiBWyvOVTcw1OySEFq5LI7381PvTBz3/dqczOLwGOE+mxGxy0SQiVdmUby tNR75+iysSx6T1KoqE7vw4+PLaE+heOhVKGiEnWUaiC7hFdH2tYEnf4besShnjHJmXFsT XnnGk2qptRCR7S+In+ZGYDSJeROvQ9kdFmuSRWyIL+f5Sc0zmOkxaZMjjfvpUEgf41KjE vj509V/h2jus0FBclpWdV/cQqQ0hTqv4KlM1MlBsPRwY9LOHhBd+uE7mWfoWaVjwWtQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056096; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=XjS8yrUpX12gMLuJm1Y0xAz4mEi3Z5KRTyszLEXEQSs=; b=fZdYSOyrCdVY22CsoIRUXVBC009aMmJ2XqdNcXqMoX1ltO/p97NkcJdlP6GkDhTDfT0t mVTD+AIaePvodVU8+th9jVd1IapQ/iBDs2q1F7EGZ67tRuQPWTdWY/RsSGj+KoXQrRas6 /kVcG2YPu7KCShMWtyggL4ts+f2kuHeV7o+98BKaTW28ZetPEY/EwN+MAH6Lph7YuZB3B rZx5m3dTcZm8PmySYUXCMiAW6lHV+BuJsm+wz1fFWmWGVFUCUWiVb8ZnSYSBg8SxSCWpL 5TuCSmXvPPsDa0Mu51SpJyo7WR2FJc/RGivewzFIr667vocQMhqM2F1sNaay6BySMMA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=vbHQ0NkR; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6AB6606A320; Thu, 19 Nov 2026 02:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=vbHQ0NkR Received: by smtp.kernel.org (Postfix) with ESMTPSA id 035D91F000C4; Thu, 19 Nov 2026 02:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056096; bh=XjS8yrUpX12gMLuJm1Y0xAz4mEi3Z5KRTyszLEXEQSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vbHQ0NkRE3WpTTQm4ru4mxFYyaYEfVe9FOuUbxcyrNOlWqnGcz8pX/p6atqF/k/+V PyfkmIRRX/5FV8n5sC1AhXxIA2aAGlsjqFtMR5fjGqVwqKgY8y/nF2eAskBZaxP6l4 ibhnpVXeFt4IptOXqM4Lan/S0FcEWMhRS96OwjEA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, VEGA , Jiayuan Chen , Eric Dumazet , Paolo Abeni , Sasha Levin Subject: [PATCH 5.15 1867/2214] tcp_bic: fix divide by zero on max_increment == 0 Date: Wed, 18 Nov 2026 15:59:03 +0100 Message-ID: <20261118150125.993601013@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiayuan Chen [ Upstream commit 8edbf6c23363563e508a61f3f26f4e4b6eec9dd5 ] max_increment is how many packets cwnd can grow per RTT, so 0 makes no sense, and bictcp_update() divides by it. Reject values below 1 when the parameter is written. Fixes: 83803034f423 ("[TCP]: Add TCP BIC congestion control module.") Reported-by: VEGA Signed-off-by: Jiayuan Chen Reviewed-by: Eric Dumazet Link: https://patch.msgid.link/20261008092641.140777-2-jiayuan.chen@linux.dev Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/ipv4/tcp_bic.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_bic.c b/net/ipv4/tcp_bic.c index 58358bf92e1b8..08f58cdeb7f80 100644 --- a/net/ipv4/tcp_bic.c +++ b/net/ipv4/tcp_bic.c @@ -27,15 +27,25 @@ */ static int fast_convergence = 1; -static int max_increment = 16; +static unsigned int max_increment = 16; static int low_window = 14; static int beta = 819; /* = 819/1024 (BICTCP_BETA_SCALE) */ static int initial_ssthresh; static int smooth_part = 20; +static int max_increment_set(const char *val, const struct kernel_param *kp) +{ + return param_set_uint_minmax(val, kp, 1, INT_MAX); +} + +static const struct kernel_param_ops max_increment_ops = { + .set = max_increment_set, + .get = param_get_uint, +}; + module_param(fast_convergence, int, 0644); MODULE_PARM_DESC(fast_convergence, "turn on/off fast convergence"); -module_param(max_increment, int, 0644); +module_param_cb(max_increment, &max_increment_ops, &max_increment, 0644); MODULE_PARM_DESC(max_increment, "Limit on increment allowed during binary search"); module_param(low_window, int, 0644); MODULE_PARM_DESC(low_window, "lower bound on congestion window (for TCP friendliness)"); -- 2.53.0