Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056229; b=NJsNMZ8eIzSGRtYdRlFPSJ7gAqKAcH8pjyMX+OXgpYEU60xohR7MBu8Lz5NGebLePt0i WwIB4rtyKSXNNN0aC6u9WfIdCT8v3s8FT85umHzj0fLpa0TQvAugSLv/Q31Yxckhy2TQJ p+Ju+dGZYl6AK74YlI7HKTPo4LclOGYBPYsJY/rMcQLnCggm3FBX2wZwjprtMvzBvKrcI rKWTMih37rOPTLFH3kVANAVPJpIl4XXOD+sIgCtiwxHHTruhpvFgCxhkDliE8PqGEgF9C Dw66MQtvdPZc4a4V6WRqTyJJaGmxNKX7xpfZAtWcFWKTw5okvfYoShz298vlvgaegMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056229; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=B7si3ZKsqqeV283lrCOfIpQqqoh3kCh0PWAsNaXTvDg=; b=hGic9teTvVVQ0PkkHgsi/Pm8PUryXebKkrihVgo+NI+vDSM7M903x3CoDSO/jbUhU0tt AhmJbGXLzlODWA6xzS+367mxSg1xwYIUDIW5nA6cULAauO/xQ14XF8cKWWUEy4BAlnLi/ BrONI9VnDN/pj4DITG1Ut9k2VwTDeHthfjWqwexxk1ShayfhAk2j/82PZXTwTuEIipHZ3 uS93jn6ivs/DzKbEjY6C5O9Qhx2srzKGyk1Vhw/XEjlbvlj1QBgTsET8gwKNIBquGhDUR 2yi5whzc+fXHejX89YIf/xBMC2b9gQ1N5mlQeRRY72rYx/ejzOnwsTWKXfsj/11coMQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rcJBV+lq; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCF17606A320; Thu, 19 Nov 2026 02:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rcJBV+lq Received: by smtp.kernel.org (Postfix) with ESMTPSA id 273AA1F000C4; Thu, 19 Nov 2026 02:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056229; bh=B7si3ZKsqqeV283lrCOfIpQqqoh3kCh0PWAsNaXTvDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rcJBV+lq2+bmuiN5JHeZ05wjRDEhLBaRjtkYfjr+hp+I8y9yPC7X2DTt4BkKXfTPE Pn/IBW0CQvE5a1YL6xzk6FQG1o37Oe07TAaYq3AMx8n728KjaRP1sTaJBEkxbfspT4 UR2LwNE8wRV5bup1lONseOtSEsd2DEUiYf4On2QU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 5.15 1914/2214] ASoC: codecs: wm8990: Fix definition of right input PGA controls Date: Wed, 18 Nov 2026 15:59:50 +0100 Message-ID: <20261118150127.643342419@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An [ Upstream commit 5bd6d05197affaf5a2d7fae0e06e7373fd839b7c ] The right input PGA boost (R12MNBST, R34MNBST) and routing (R12MNB, R34MNB) bits are in Input Mixer4 (R42), not in Input Mixer3 (R41), where these controls write the left channel bits. Fixes: f10485e79882 ("[ALSA] ASoC: Add WM8990 driver") Assisted-by: Claude:claude-opus-5-5 Signed-off-by: HyeongJun An Reviewed-by: Charles Keepax Link: https://patch.msgid.link/818cf8d7ae81fa46c67cd5b4d01291a63f44c9a1.1791959026.git.sammiee5311@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm8990.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8990.c b/sound/soc/codecs/wm8990.c index 938940777e5dc..5a1570598771c 100644 --- a/sound/soc/codecs/wm8990.c +++ b/sound/soc/codecs/wm8990.c @@ -97,8 +97,8 @@ static const struct snd_kcontrol_new wm8990_snd_controls[] = { SOC_SINGLE("LIN12 PGA Boost", WM8990_INPUT_MIXER3, WM8990_L12MNBST_BIT, 1, 0), SOC_SINGLE("LIN34 PGA Boost", WM8990_INPUT_MIXER3, WM8990_L34MNBST_BIT, 1, 0), /* INMIXR */ -SOC_SINGLE("RIN12 PGA Boost", WM8990_INPUT_MIXER3, WM8990_R12MNBST_BIT, 1, 0), -SOC_SINGLE("RIN34 PGA Boost", WM8990_INPUT_MIXER3, WM8990_R34MNBST_BIT, 1, 0), +SOC_SINGLE("RIN12 PGA Boost", WM8990_INPUT_MIXER4, WM8990_R12MNBST_BIT, 1, 0), +SOC_SINGLE("RIN34 PGA Boost", WM8990_INPUT_MIXER4, WM8990_R34MNBST_BIT, 1, 0), /* LOMIX */ SOC_SINGLE_TLV("LOMIX LIN3 Bypass Volume", WM8990_OUTPUT_MIXER3, @@ -377,9 +377,9 @@ SOC_DAPM_SINGLE_TLV("Record Right Volume", WM8990_INPUT_MIXER4, WM8990_RDBVOL_SHIFT, WM8990_RDBVOL_MASK, 0, in_mix_tlv), SOC_DAPM_SINGLE_TLV("RIN2 Volume", WM8990_INPUT_MIXER6, WM8990_RI2BVOL_SHIFT, 7, 0, in_mix_tlv), -SOC_DAPM_SINGLE("RINPGA12 Switch", WM8990_INPUT_MIXER3, WM8990_L12MNB_BIT, +SOC_DAPM_SINGLE("RINPGA12 Switch", WM8990_INPUT_MIXER4, WM8990_R12MNB_BIT, 1, 0), -SOC_DAPM_SINGLE("RINPGA34 Switch", WM8990_INPUT_MIXER3, WM8990_L34MNB_BIT, +SOC_DAPM_SINGLE("RINPGA34 Switch", WM8990_INPUT_MIXER4, WM8990_R34MNB_BIT, 1, 0), }; -- 2.53.0