Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056477; b=4TLYAEoIsVeB0viSDXzcds2+pUd9YiNvH0s7bmOhiQMEtzGk4Izb13jMM7l07IvJrYf0 km/CD9+zlZAo+HBa839shcVNvmk8vAOeb2GPICgvbNJaJm8DcDo3MSZ30S3dEl6DF9BfQ YEQG4ALsQhPOo4ZnvubWXy8VW2ThZmhhiOHV+dz1+behiDLcBTtpQ9DmLIbLrANoyJMTQ ij5DYhjDu/NvYxM578WF6aLE3Zqb8FDKh6+Uwu1CeIgRTGS6yqAX9H8L2JZr45S5qoaXL 6K6mnwC8m6rQyZPj4edRzXC5q/7Gd3RzG6JIYJYKjngTXpFIy+fmlQiol08+SD806iA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056477; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=41f8IE9TIpUkRiB4eLZQXuDMdMYLaSGMs0hWvAmx8Jg=; b=C03qnIQxUG3FVnBBX27Jx04RsEO2qC93irwshzS38wPR9pitMR8zrVI0ucqAqQJDrmm7 s/XMqPowhc+rtHlNQ2wFOfvRj5xBl3CU6o7wNbavWBzmrrxPKQbW6OdTFObYr5HIcGsUY MTOghO4m+7DMr1TiwBJeAr6tMqsLNmQnutXmCYKosScoV9HXW5Cb9CpzDy8e9qgM8w23k DUCQhB9YsAeRKmYnLzCln+Ju0U4pSJuVbENWN0IUT1hdZ07r8Uzn36qyGuFSV9Y9hH4Bj iIs4fFBJWgjX2dnV8sPxrATF1OKkDvzKJD1or1cN3ec/jsVoNFHtEgQKhm5dgtqHSsg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=0AORtMWP; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FE61606A32F; Thu, 19 Nov 2026 02:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=0AORtMWP Received: by smtp.kernel.org (Postfix) with ESMTPSA id 556B81F000C7; Thu, 19 Nov 2026 02:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056476; bh=41f8IE9TIpUkRiB4eLZQXuDMdMYLaSGMs0hWvAmx8Jg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0AORtMWPN9IkVIo6SBra9Omuj1sSCTvfPfu3mE9hqNPg2B3LyBgnquNS+aS3w2ZlL FgVcQ6SYdGLDzdauyDTDx0LPCUsabsSUwyx9ALuLoFXTUluAeagNWAgGX5Dhl1xv+w KnXRJT9mxCWP9H8Jg2sUr7+zxetyx5gsdj1YvwNw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Donggeun Yoo , Steven Rostedt , Sasha Levin Subject: [PATCH 5.15 2003/2214] tracing: Print a signed histogram key as signed Date: Wed, 18 Nov 2026 16:01:19 +0100 Message-ID: <20261118150130.904055025@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Donggeun Yoo [ Upstream commit d3e0dfc1ba49a0ab6aeddbb4bcde4bfc0e171a02 ] A histogram sorts its rows by the key named in sort=, and for a key over a signed event field it sorts them signed: create_tracing_map_fields() picks the comparison function with else cmp_fn = tracing_map_cmp_num(field->size, field->is_signed); hist_trigger_print_key() does not look at is_signed at all. Every numeric key is printed with %llu, so a sorted histogram over a signed field comes out looking unsorted. syscalls/sys_exit_lseek carries "long ret", which SYSCALL_FIELD() marks signed and which is negative on every error: # echo 'hist:keys=ret:sort=ret' > events/syscalls/sys_exit_lseek/trigger # echo 1 > events/syscalls/sys_exit_lseek/enable # (five lseek(2) calls returning -ESPIPE, -EINVAL, -EBADF, 0 and 100) # cat events/syscalls/sys_exit_lseek/hist { ret: 18446744073709551587 } hitcount: 1 { ret: 18446744073709551594 } hitcount: 1 { ret: 18446744073709551607 } hitcount: 1 { ret: 0 } hitcount: 1 { ret: 100 } hitcount: 1 The rows are in ascending order and the numbers are not, because the three leading ones are -29, -22 and -9 rendered as their two's complement. Take the rendering from the same place the sort order comes from: the event field when the key has one, and the hist_field itself when it does not. The same histogram then reads { ret: -29 } hitcount: 1 { ret: -22 } hitcount: 1 { ret: -9 } hitcount: 1 { ret: 0 } hitcount: 1 { ret: 100 } hitcount: 1 A ".buckets" key stays unsigned here, and not because it is right. hist_field_bucket() divides as unsigned, so the group holding S64_MAX also holds S64_MIN, reported at https://lore.kernel.org/all/20260914054614.82A9B1F000FF@smtp.kernel.org/ Printing that group signed would name a range that does not contain S64_MIN, so the grouping has to be fixed with it, in a patch of its own. Link: https://patch.msgid.link/20260917045918.370993-1-donggeunyoo.kernel@gmail.com Fixes: 7ef224d1d0e3 ("tracing: Add 'hist' event trigger command") Signed-off-by: Donggeun Yoo Signed-off-by: Steven Rostedt Signed-off-by: Sasha Levin --- kernel/trace/trace_events_hist.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 3bb4076fd71a5..dbe10dfe17ffe 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -207,6 +207,14 @@ static u64 hist_field_pstring(struct hist_field *hist_field, return (u64)(unsigned long)*addr; } +static bool hist_field_is_signed(struct hist_field *hist_field) +{ + if (hist_field->field) + return hist_field->field->is_signed; + + return hist_field->is_signed; +} + static u64 hist_field_log2(struct hist_field *hist_field, struct tracing_map_elt *elt, struct trace_buffer *buffer, @@ -4835,7 +4843,11 @@ static void hist_trigger_print_key(struct seq_file *m, (char *)(key + key_field->offset)); } else { uval = *(u64 *)(key + key_field->offset); - seq_printf(m, "%s: %10llu", field_name, uval); + if (hist_field_is_signed(key_field)) + seq_printf(m, "%s: %10lld", field_name, + (s64)uval); + else + seq_printf(m, "%s: %10llu", field_name, uval); } } -- 2.53.0