Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056708; b=H6Y7KthAy1l3paBEECzNPpa+feWKZjR5/1pKdTXsVxjARruxxNzSHKzOFyipX7aRJ7L/ xFX0X34EtTBauXFQnG7L8iyXwiDn4Ro6ArwY+fefHs8O21VpIkpPgvsYm+lMojzKly3gw Df97khdO/cBBneTQWADmVbr5SWelzQvM9XEB2y5YxNiyKho4dI4HqvxQ/7uCOxLNv/G1B lEoDe+S6C7gJRsgVKTkwz5VPHlkO32etUadWvNg0UmfAtlBcW3Uoqj8XxwUOPUXX+iH5P RtX2y4ilqBW+n0j94PeAa/Sf7SC7+dggStj0jmSx1MZU3NIGcY9sUhi+LrHdzL3IKlA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056708; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=tK+zE0ZsXkveo/TuV7kHD1h08TalkDOvcAFanZ8vEvc=; b=YA5OTdL2EaGhz+P8cSBqGWMskbAjpaki3k5ehsw1lPwzkvxGH5lKuvVjUv062jJvaeTQ zolurMggrmmv6NVHNF4zC/jW1zmhGZVb0uFGG1F7/Wt9wXFe/Cd0LhauiJBvNMLZGQ+CE IZGaLL+gk7pmWFDRak+Sr0kITC7TnpbpCjygdGCU5FpTtw7TRGe/9U6hoC892Wti2mwsq ZMw/4i/GkZw863ChbPCLGhWCh87miGpxPZNm59PYGS5NA3TO5m23vkhQLuKBP6yBHPuVG w49nQ2e3c69YF7mHbYf0YVKSRZ5m8FcDttG0KVjHwb+96tIawcdlZLVvKJw/nEuT/Pw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="x48/PMmh"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E372606A320; Thu, 19 Nov 2026 02:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=x48/PMmh Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7ED21F000C4; Thu, 19 Nov 2026 02:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056708; bh=tK+zE0ZsXkveo/TuV7kHD1h08TalkDOvcAFanZ8vEvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=x48/PMmhDqHd5F27wOnAzSHU2YElgFSoYcQ2VDm6GhTV/4yTwCLXUCcdIfDByxzeO XBX5OCB1p7azOQutGHSkwK2gbaKo++28yNwGYkPusUlqNs9VtqQRGAQpOO684Ulu7m xS3uSes71sbVWWMK4M2rCaDFS6fdWH4XC4NGg+Ss= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+d270af829aca04e783fc@syzkaller.appspotmail.com, Aleksandr Nogikh , Alan Stern , Sasha Levin Subject: [PATCH 5.15 2033/2214] usb: gadget: dummy_hcd: prevent unbind via sysfs Date: Wed, 18 Nov 2026 16:01:49 +0100 Message-ID: <20261118150132.078112958@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Nogikh [ Upstream commit bdf12cde30830d46a8ef1ba93986356f1164b4f1 ] The dummy_hcd (Host Controller) and dummy_udc (Device Controller) are implemented as two separate platform drivers that share the same underlying state (struct dummy). They are designed to be created and destroyed together during the module's init and exit phases. If userspace forces the dummy_hcd driver to unbind from the device via sysfs, dummy_hcd_remove() cleans up the host controllers and sets the pointers to NULL (dum->hs_hcd = NULL). However, the dummy_udc driver is still bound to its device, meaning the USB gadget is still registered with the udc-core subsystem. If a new gadget driver is subsequently registered, it binds to the still-registered dummy_udc gadget, invoking the dummy_udc_start() callback. This callback attempts to retrieve the HCD state using gadget_to_dummy_hcd(), which returns NULL because of the unbind. This results in a null-pointer dereference: Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] ... RIP: 0010:dummy_udc_start+0xd0/0x1f0 drivers/usb/gadget/udc/dummy_hcd.c:1022 ... Call Trace: usb_gadget_udc_start_locked drivers/usb/gadget/udc/core.c:1237 [inline] gadget_bind_driver+0x3a8/0x9e0 drivers/usb/gadget/udc/core.c:1667 call_driver_probe drivers/base/dd.c:-1 [inline] really_probe+0x254/0xae0 drivers/base/dd.c:706 __driver_probe_device+0x1e8/0x360 drivers/base/dd.c:868 driver_probe_device+0x4f/0x240 drivers/base/dd.c:898 __driver_attach+0x339/0x600 drivers/base/dd.c:1292 bus_for_each_dev+0x23b/0x2c0 drivers/base/bus.c:383 bus_add_driver+0x345/0x670 drivers/base/bus.c:763 driver_register+0x23a/0x320 drivers/base/driver.c:174 usb_gadget_register_driver_owner+0xf9/0x270 drivers/usb/gadget/udc/core.c:1752 raw_ioctl_run drivers/usb/gadget/legacy/raw_gadget.c:596 [inline] raw_ioctl+0x1541/0x41c0 drivers/usb/gadget/legacy/raw_gadget.c:1307 Adding NULL checks to the UDC callbacks is not a robust solution because there is no synchronization between dummy_hcd_remove() and the UDC callbacks, which would result in a use-after-free race condition if the HCD were unbound concurrently. Fix this by setting .suppress_bind_attrs = true in both driver definitions. This prevents userspace from unbinding these drivers dynamically, ensuring their lifecycles remain strictly synchronized with the module's load/unload process. Fixes: d9b762510c18 ("[PATCH] USB dummy_hcd: Use separate pdevs for HC and UDC") Assisted-by: Gemini:gemini-3.5-flash Gemini:gemini-3.1-pro-preview syzbot Reported-by: syzbot+d270af829aca04e783fc@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=d270af829aca04e783fc Link: https://syzkaller.appspot.com/ai_job?id=7a763ada-c07c-458f-9fea-f7e913dc1f2f Signed-off-by: Aleksandr Nogikh Acked-by: Alan Stern Link: https://patch.msgid.link/18ec3122-7566-49e5-9964-1028857405b1@mail.kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/dummy_hcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index 134ce1bb25372..004a3054065eb 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -1181,6 +1181,7 @@ static struct platform_driver dummy_udc_driver = { .resume = dummy_udc_resume, .driver = { .name = gadget_name, + .suppress_bind_attrs = true, }, }; @@ -2790,6 +2791,7 @@ static struct platform_driver dummy_hcd_driver = { .resume = dummy_hcd_resume, .driver = { .name = driver_name, + .suppress_bind_attrs = true, }, }; -- 2.53.0