Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056683; b=5QgYlNaPdaX/ZBMnwsZn7cEJdhwh949FZi7K8QEuRfsGHuAoNsXdJnVQBQJ+2lkVGzL/ Oxj3/yc0hp2R/IM2vA/lT/Vcbt9c0zu793N8M0w4PI1ooi/IB0drXZ+SLpmCSwhMCqTbi eHPwq5r47k4laLiRevIRCA6hToyDwVDSRQBrAI1F9VwK8CCGg9Dskaz0kEi900NnpVb55 Ba4f9EiDH3cnoWwut4JTNd+K2Wq9zso9fKsBxccDpJQTS3YgV8/EiAQLpdvRpOcevA+EM PdhJFELGoVLG5pxup3ATwEspZ/3iS7fOVhXTO/9XB78usSMUe497BOB7U38e4+Z5hzg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056683; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=+KRHicYVrbQ02Nm+1uqHxKL3rwA9W+WbbOkEuyjnJKg=; b=AP536AALystd7M1etaXD44FwZkIEv6W6BUApQklwlWsGX67A3MItuazLdotcmtrsET8P iZBoxSDm3eh172baGpvBg6UvKV1/8lPYb6hYnaIEzOG9h2sgha2Lse57Ol3182hiqOwXL S71zpvY46EmsxzNiMP4VyBImgfre4ykBlSqwMqdMPqe0KjGutVDZwQ1nbHNWxLdcK0tAL ZDPz1L3zDQvvwM9ZWB4MXqJG4Yrs1vyQFzO71Wk+RSVVa2WGvC/eSFCQR0tb2NzUSOfUO RI7N4L/5Zz7KoG94laTWRZi89u2qVJ50dJFTHZqDqDtcFUw1H/ipowr5I87JUbNOdFA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=JHIMMoFe; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8553A606A320; Thu, 19 Nov 2026 02:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=JHIMMoFe Received: by smtp.kernel.org (Postfix) with ESMTPSA id D61D51F000C4; Thu, 19 Nov 2026 02:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056683; bh=+KRHicYVrbQ02Nm+1uqHxKL3rwA9W+WbbOkEuyjnJKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JHIMMoFeU6DF0xhkchoRg/GqCBmt+y+J9b8qFIbqqlrGQCU1DCQPa+++SVnVXAQNs oPlaXG6PM3N6owcte3ARF7DFRtwQRf94+XQ4Griy3hLS1aNaY3T9Z98LdclITFLYAO AINCGk3CKs8HCvASoUSWw/+pvk3VWlxn6SLSFANk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 5.15 2073/2214] platform/x86: gpd pocket fan: Cancel work before releasing GPIOs Date: Wed, 18 Nov 2026 16:02:29 +0100 Message-ID: <20261118150133.558815389@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak [ Upstream commit 9962770049c715fc30a7b3274d8f245167c0a410 ] The fan worker changes the direction of both GPIOs and schedules its next run. Its managed cancellation action is registered before the GPIOs are acquired, so devres releases the GPIOs before cancelling the work. A running worker can therefore change a GPIO after the driver has released it. Register the work cancellation action after both GPIO acquisitions. This makes devres cancel and drain the worker before releasing either GPIO. No work has been queued yet if GPIO acquisition or action registration fails. This issue was identified as part of our ongoing research while reviewing kernel code. Fixes: b82a7b018b93 ("platform/x86: gpd pocket fan: Clean-up by using managed work init") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/179229442299.3956787.17526066623947466315.gpd-pocket-fan@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/gpd-pocket-fan.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/gpd-pocket-fan.c b/drivers/platform/x86/gpd-pocket-fan.c index 7a20f68ae2061..01f9676fc0f43 100644 --- a/drivers/platform/x86/gpd-pocket-fan.c +++ b/drivers/platform/x86/gpd-pocket-fan.c @@ -153,10 +153,6 @@ static int gpd_pocket_fan_probe(struct platform_device *pdev) return -ENOMEM; fan->dev = &pdev->dev; - ret = devm_delayed_work_autocancel(&pdev->dev, &fan->work, - gpd_pocket_fan_worker); - if (ret) - return ret; /* Note this returns a "weak" reference which we don't need to free */ fan->dts0 = thermal_zone_get_zone_by_name("soc_dts0"); @@ -175,6 +171,11 @@ static int gpd_pocket_fan_probe(struct platform_device *pdev) if (IS_ERR(fan->gpio1)) return PTR_ERR(fan->gpio1); + ret = devm_delayed_work_autocancel(&pdev->dev, &fan->work, + gpd_pocket_fan_worker); + if (ret) + return ret; + gpd_pocket_fan_force_update(fan); platform_set_drvdata(pdev, fan); -- 2.53.0