Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056816; b=SJEwjSCGYhr+hdMuvzjxkfhkXOQrmbHc+AM6/WGFTOMCLnASD4IrZQPkLta15FD3ucQG 5728/rgeXzRT7q83MI9hRz/VoO8cje+BpIrm/UwijPPNovWCRcQvnZcvV+zRgUZ5kNpWP WYR8wZ0Fw5M03i+O3kIX4rWAyxW66PawPt3FwyKpwxy4xSjxrjY9C/0xrqpfudWTlnfyv LXYgGT8jjig0+BSDGghLhoQFKjJDUDjox/tWmag8Mahx2YuDgjbD9xE6nfw+n3iblFcAd yA0afPHI7+SFcU7NsbdOpCYXpMLD+QjrK4u38bATim8k3U3eb3v0SCoD3CKqpi3H7tQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056816; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=sXEBWo+L+mUV29lVKtU/LehqNZZTmhg25Ka0BbwdAx4=; b=edlF1p8kxa+He013hIorJwVIsvy+YtnVUk42DSJVn/havUUdE/ZVhK/zrxUhGFg0XLEN mSDGYmWsWjT+0QvbqY87rRYEOc7Wz3+BSQLqNoR+cl1zKrEeRYuncNm9Ok7VbJyu4hD6d zdbRcXE7Rcg8iw8qJsKNAt99DXvKg/BKjjKthptrJslHNj9S/9Pxl96NjmTCzqSExLvqI dVD/I/FdiGzEqiD8MVEwx3i4DrXxe4G0kjSq1D1VNRc/8tfvWdmdRt1Cf/Uk6BRpQAa2K SfUaigGMVUz8bUch8TOE4KND8TOU+iJIOjcS7IvMH6EsShoJqsazaQtMnkqtoZEFjhA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=09pwqZT2; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE03A606A31C; Thu, 19 Nov 2026 02:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=09pwqZT2 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 390791F000C4; Thu, 19 Nov 2026 02:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056815; bh=sXEBWo+L+mUV29lVKtU/LehqNZZTmhg25Ka0BbwdAx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=09pwqZT2awBjvC7cljZt/HvEm5Txa8mbZjC0JUTQqm6nPlyfwyfebHYrcbhBSjp+m ULDY1BajNdXkDtnLYCXtb3IeeYF8owWuAYHvfz54Xk1SYKsXkzWSxnY4aKgE+OuXa/ HiXTvZUdB+1VB1Nj8vW2LmwTPh2jFE/mpVX4q47s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Edward Adam Davis , Andrew Morton , syzbot+1f0fbc2561b3e5d51b91@syzkaller.appspotmail.com, Bradley Morgan , Pingfan Liu , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.15 2120/2214] kernel/reboot: avoid potential deadlocks during suspension Date: Wed, 18 Nov 2026 16:03:16 +0100 Message-ID: <20261118150135.387251872@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward Adam Davis [ Upstream commit 66644b992f25f6a33775788c8b69a8bb3d41ad67 ] Invoking reboot with LINUX_REBOOT_CMD_SW_SUSPEND causes kernel/reboot.c to acquire system_transition_mutex and invoke hibernate(). hibernate() calls lock_system_sleep(), which sets PF_NOFREEZE on current and attempts to acquire system_transition_mutex again, potentially hitting: WARNING: possible recursive locking detected -------------------------------------------- syz.3.5755/5950 is trying to acquire lock: ffffffff8fc04760 (system_transition_mutex){+.+.}-{4:4}, at: lock_system_sleep+0x49/0x70 kernel/power/main.c:71 but task is already holding lock: ffffffff8fc04760 (system_transition_mutex){+.+.}-{4:4}, at: __do_sys_reboot kernel/reboot.c:774 [inline] ffffffff8fc04760 (system_transition_mutex){+.+.}-{4:4}, at: __se_sys_reboot+0x223/0x460 kernel/reboot.c:738 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(system_transition_mutex); lock(system_transition_mutex); *** DEADLOCK *** May be due to missing lock nesting notation locks held by syz.3.5755/5950: 1, last CPU#0: #0: ffffffff8fc04760 (system_transition_mutex){+.+.}-{4:4}, at: __do_sys_reboot kernel/reboot.c:774 [inline] #0: ffffffff8fc04760 (system_transition_mutex){+.+.}-{4:4}, at: __se_sys_reboot+0x223/0x460 kernel/reboot.c:738 Call Trace: lock_system_sleep+0x49/0x70 kernel/power/main.c:71 hibernate+0x162/0x680 kernel/power/hibernate.c:784 __do_sys_reboot kernel/reboot.c:816 [inline] Move the suspension operation outside the scope protected by lock system_transition_mutex. Link: https://lore.kernel.org/20261020010559.23031-1-eadavis@sina.com Fixes: 55f2503c3b69 ("PM / reboot: Eliminate race between reboot and suspend") Signed-off-by: Edward Adam Davis Signed-off-by: Andrew Morton Reported-by: Closes: https://syzkaller.appspot.com/bug?extid=1f0fbc2561b3e5d51b91 Tested-by: Reviewed-by: Bradley Morgan Cc: Pingfan Liu Cc: "Rafael J. Wysocki" Signed-off-by: Sasha Levin --- kernel/reboot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/reboot.c b/kernel/reboot.c index c0271417dbed5..6fb3230d36e53 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -386,8 +386,8 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd, #ifdef CONFIG_HIBERNATION case LINUX_REBOOT_CMD_SW_SUSPEND: - ret = hibernate(); - break; + mutex_unlock(&system_transition_mutex); + return hibernate(); #endif default: -- 2.53.0