Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056836; b=BsSlwSJr6NCM6q2ReOnLiQGfjVibDm2Wz1L4HQj4hhOhDhIOE/qfzMD2m8IPAINkdcwA RfRIq5Lti91v2HauUJvQkHRKBgy0uOqgx4DggbvldQUpZPDBN9EP8WLfEqSxTTYXmGW4e 5cAktkzaDKRO8lcE+aGg5qe9iT+KpIh0n2GEND1E4uyKg4odK9eE4g1ZvKLiEGjbtuZ1E 87zA9/let5sMjWCNn+s43Xn6TwG49Sn/vSXVjPSWMYMtwetdUubwdzgY9IZ41sjYTTk+s XYSzD0kFusSbuUAjliSo6/Ri/sxfSyG4bCDUixGfySjm2irX6HjESEnNXS1wUivcEVQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056836; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=xXP0iFRlizqtuBjc8n+7aJuOzB3J/MKVU1iUm+CdJec=; b=NEK8dTZmZYfgkDmRiewGw1aN+iVenouqBsWb6Va5wrQ1qaWqnhYLGmme+Fzv3MQwWuqk OL8HlWesVmC7ElmBcqkiPK9BSvq7ai/bybKfXcNo9dr3BSk/5vbEPstiyWiAcKibT6gTU xQNbmiz4w7dNhMCPo1IFwXe2fyEd/xxX9Xk82fEc63gjE7kIQUjibZwVq6TOp0MAIW7Py sXQgdMr1ne8JEIggz6AkNqO3WbBegKQ1derZWfquM8AbrJ341O2J2cp8usS2qSI25tthX UQU/VlldHIAhD0MIfhXCkfJ4SxMz2VoydcBUKa/u2GXLb/FUE6RDKiS7FYQUGr4nwVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="z4ynT/V6"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15ED460A2607; Thu, 19 Nov 2026 02:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=z4ynT/V6 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 272211F000C4; Thu, 19 Nov 2026 02:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056835; bh=xXP0iFRlizqtuBjc8n+7aJuOzB3J/MKVU1iUm+CdJec=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=z4ynT/V6+YMdpyWlmnThZtL4i6h3sdmuO+mIcabbLTw413jxN1HehJjVw0stajr7L AuMo4XMmRyyr9/HLjqCLCxbouyr2s5S8kqBhEwXFdNXLCNOsx9WW8qwckk/vh3HGS6 2ue8oBVV58Fhhj88cSogKzGjj0pe+ZYXU9TLHE1k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Henry Martin , Dave Miller , Sasha Levin Subject: [PATCH 5.15 2122/2214] netlink: fix out-of-bounds bitmap access clearing stale mc groups Date: Wed, 18 Nov 2026 16:03:18 +0100 Message-ID: <20261118150135.458798806@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Henry Martin [ Upstream commit 6430fb7f1cc4e329e386521b7b208df443de92f2 ] netlink_realloc_groups() sizes nlk->groups to the number of groups that exist at bind/ADD_MEMBERSHIP time. When more multicast groups are registered later (e.g. a new genl family), existing sockets keep their smaller bitmap. When clearing a multicast group of a departing family, __netlink_clear_multicast_users() runs netlink_update_socket_mc() on each socket on mc_list, which does test_bit()/__assign_bit() on group - 1 with no regard to nlk->ngroups. Skip sockets whose bitmap predates the group: such a socket can never have joined it. The overflow windows differ per architecture, both needing privileged module (un)loading. On 32-bit kernels the ~54 dynamically allocated genl groups already exceed the initial 32-bit bitmap, so the table can grow there directly. On 64-bit kernels the same in-tree set fits the initial 64-bit bitmap only while allocation stays contiguous: genl_allocate_reserve_groups() takes the first free contiguous range and unregister does not compact, so an unload/reload sequence can fragment the ~59 free IDs until no fitting range remains, forcing the table past 64 bits and reaching the same stale-bitmap overflow on the next family teardown. This issue was discovered by Tencent CodeBuddy Security. Fixes: 84659eb529b3 ("[NETLIKN]: Allow removing multicast groups.") Signed-off-by: Henry Martin Signed-off-by: Dave Miller Signed-off-by: Sasha Levin --- net/netlink/af_netlink.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 3671071482a02..d3536f9d50cb3 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2168,8 +2168,12 @@ void __netlink_clear_multicast_users(struct sock *ksk, unsigned int group) struct netlink_table *tbl = &nl_table[ksk->sk_protocol]; struct hlist_node *tmp; - sk_for_each_bound_safe(sk, tmp, &tbl->mc_list) + sk_for_each_bound_safe(sk, tmp, &tbl->mc_list) { + /* bitmap predates the group, can't be a member */ + if (group - 1 >= nlk_sk(sk)->ngroups) + continue; netlink_update_socket_mc(nlk_sk(sk), group, 0); + } } struct nlmsghdr * -- 2.53.0