Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795056952; b=E/l03ve2VpWxkXaIbeVxh3HvookRCfRA1Tj79ehGr3XZbaTrCPv70IEq1FIJLEsMi7tV eqr+o2L0nXjqxdr1ADtkfD6kLEprjLe8liD0CZKGDoPKFsTeZlMjtpFODGFKxq+jLQFjo nXHr3r/OpMy8N3UTp9H7vyvnYlmOTDxobghHKYtyiEU2HlepW2Z+NrfIkRASZu60lzPuv H3xYNnwu6qxVAAmN5S9WVAo6kcD+2HIQm4gPp/E0zxWy9vHNfTEyUIykzBzLx4tkiqZUq 95nbynQfOz9u9CgS1Ap7zmDjIOAN2XTLOqxd24zwVMtFw0PT7zsM7AMv/X54EZvqtRw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795056952; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=KwXPR/V0XUiz5JuxeqCPtv/IAdZGX43TjZp+9UhQUjw=; b=EJnPwUd4xwenHDvzeRAOGCDxT0hY+PVfRP4hEQQ3QPD+69b2N92zB1/GoGPePGNxuZ6Q KqDu+JJQWZtS3cZpJEz+VfUtivrCAz4yM9ZDjdSPyR4M4ddlIWg4QTybhXQKQCs6ACScd +gnvLV+ohfp27G5AtYbcr5/iELdB20xEa3MWQVu3OYkBCU4IVJgeMx8JRWhfeSv9SQdWr UB1OzOXq6WCJz4QLuDvLQVtOnY+L2Kah2r1099S/D2scXMk8tykhVHMVLN6jaAXqBdTyo Po/EdYMQ8pgYRtegLRdjcYnJx0xcO+GHLoE7dONMjIsOx3/ZxLtbVER7nzwoLmuzB7A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=adKUWxHU; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8331D606A31C; Thu, 19 Nov 2026 02:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=adKUWxHU Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0DA51F000C4; Thu, 19 Nov 2026 02:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795056952; bh=KwXPR/V0XUiz5JuxeqCPtv/IAdZGX43TjZp+9UhQUjw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=adKUWxHU+UB1cuI1cp/IkrLSYlLZLVeoPJh8oIS0RrpT8CdvJ6T0m5K9eqtLe0YSw elg1lG2Ux0/p7wFAZUPIFRRePv7YO1surHyx7mnSoo3tzW8PMppubiWebhSTOgeb1P +VGC8zjgkEuEnq/zW8+HXQpMUMRCq7HBgjROZ9Bk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jerome Brunet , Brian Masney , Sasha Levin Subject: [PATCH 5.15 2130/2214] clk: cdce925: Size the PLL child name buffer for any int Date: Wed, 18 Nov 2026 16:03:26 +0100 Message-ID: <20261118150135.764883201@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jerome Brunet [ Upstream commit e9e6b4dc303dff637ef725aca4f4968d7600798b ] The PLL child node name is built from "PLL%d" in a 6 byte stack buffer. The PLL index is bounded by the chip's num_plls, at most 4, but GCC cannot see that bound and, with W=1, warns that the formatted string may not fit. Make the buffer large enough to hold any int and use snprintf() with sizeof() so the size stays tied to the declaration. Fixes: 19fbbbbcd3a3 ("Add TI CDCE925 I2C controlled clock synthesizer driver") Signed-off-by: Jerome Brunet Link: https://patch.msgid.link/20261014-cdce925-truncate-child-name-v1-1-00136be00c49@baylibre.com Signed-off-by: Brian Masney Signed-off-by: Sasha Levin --- drivers/clk/clk-cdce925.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c index 470d91d7314db..f118205ffe13b 100644 --- a/drivers/clk/clk-cdce925.c +++ b/drivers/clk/clk-cdce925.c @@ -646,7 +646,12 @@ static int cdce925_probe(struct i2c_client *client, int i; int err; struct device_node *np_output; - char child_name[6]; + /* + * The PLL number isn't a compile time constant so GCC can't infer + * the number. Make the stack buffer large enough to hold any int + * so Wformat-truncation does not complain. + */ + char child_name[15]; struct regmap_config config = { .name = "configuration0", .reg_bits = 8, @@ -718,7 +723,7 @@ static int cdce925_probe(struct i2c_client *client, dev_err(&client->dev, "Failed register PLL %d\n", i); goto error; } - sprintf(child_name, "PLL%d", i+1); + snprintf(child_name, sizeof(child_name), "PLL%d", i + 1); np_output = of_get_child_by_name(node, child_name); if (!np_output) continue; -- 2.53.0