From: Arun Iyengar Date: Fri, 20 Nov 2026 02:49:14 +0000 Subject: [PATCH v2 1/2] media: verisilicon: Don't report VDPU2 decoder errors as success MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261120-vdpu2-errreset-v2-1-8f4ef55e6dee@gmail.com> References: <20261120-vdpu2-errreset-v2-0-8f4ef55e6dee@gmail.com> In-Reply-To: <20261120-vdpu2-errreset-v2-0-8f4ef55e6dee@gmail.com> To: Nicolas Dufresne , Benjamin Gaignard , Philipp Zabel , Mauro Carvalho Chehab , Heiko Stuebner , Jonas Karlman , Boris Brezillon , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arun Iyengar , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1795142953; l=1243; i=aiyengar1990@gmail.com; s=20261110; h=from:subject:message-id; bh=pmz+6zoUL7toWQYosmuS4NH+xU1lJuYNQV3oDGrhPbs=; b=BDh2pWVPFr77FF11sME0qilG5geg/tyt3eY9phIjzcv/4CUISB7PCsPZP4ygzi15iLdIHKJwr YaT9K7/UxTpDfHsfEnyR6SoWgpMbieFVUIFumPnUFRY/RPZO7DmTGVm X-Developer-Key: i=aiyengar1990@gmail.com; a=ed25519; pk=zXpRgUTrhaFe6jLyPqbBy3ccfkj04w0g2690Wv3mg+0= X-Endpoint-Received: by B4 Relay for aiyengar1990@gmail.com/20261110 with auth_id=1480 List-Id: B4 Relay Submissions The VDPU2 interrupt handler completes the job as done whenever the decoder raised an interrupt. DEC_IRQ is set for every interrupt, including timeouts, bus errors and stream errors, so failed decodes are returned to userspace as valid frames. Check the picture ready bit instead, as the G1 handler does. Fixes: 879dee56a40c ("media: rockchip/vpu: Add MPEG2 decoding support to RK3399") Cc: stable@vger.kernel.org Signed-off-by: Arun Iyengar --- drivers/media/platform/verisilicon/rockchip_vpu_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c index 02673be9878e..4bc1bdb41c70 100644 --- a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c +++ b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c @@ -391,7 +391,7 @@ static irqreturn_t rockchip_vpu2_vdpu_irq(int irq, void *dev_id) u32 status; status = vdpu_read(vpu, VDPU_REG_INTERRUPT); - state = (status & VDPU_REG_INTERRUPT_DEC_IRQ) ? + state = (status & VDPU_REG_INTERRUPT_DEC_RDY_INT) ? VB2_BUF_STATE_DONE : VB2_BUF_STATE_ERROR; vdpu_write(vpu, 0, VDPU_REG_INTERRUPT); -- 2.55.0