From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 1/6] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source() Date: Fri, 19 Oct 2018 13:27:54 -0700 Message-ID: <20264195.uoZKBpxqQI@dk-thinkpad-x260> References: <20181011004124.4110-1-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35C026E53E for ; Fri, 19 Oct 2018 20:28:14 +0000 (UTC) In-Reply-To: <20181011004124.4110-1-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkbmVzZGF5LCBPY3RvYmVyIDEwLCAyMDE4IDU6NDE6MTkgUE0gUERUIEpvc8OpIFJvYmVy dG8gZGUgU291emEgd3JvdGU6Cj4gQm90aCBmdW5jdGlvbnMgaGF2ZSB0aGUgc2FtZSBjb2RlIHRv IGRpc2FibGUgUFNSLCBzbyBsZXQncyByZXVzZSB0aGF0Cj4gY29kZSBpbnN0ZWFkIG9mIGR1cGxp Y2F0ZS4KPiAKPiBTdWdnZXN0ZWQtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4u cGFuZGl5YW5AaW50ZWwuY29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFu LnBhbmRpeWFuQGludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRo aW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgoKPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2Jl cnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCA1MCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBpbmRleCA0MjNjZGY4NDA1OWMuLmY2OThiM2Y0 NWM2ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gQEAgLTY1Nyw2ICs2NTcsMjUg QEAgdm9pZCBpbnRlbF9wc3JfZW5hYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAlt dXRleF91bmxvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gIH0KPiAKPiArc3RhdGljIHZvaWQg aW50ZWxfcHNyX2V4aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4g Kwl1MzIgdmFsOwo+ICsKPiArCWlmICghZGV2X3ByaXYtPnBzci5hY3RpdmUpCj4gKwkJcmV0dXJu Owo+ICsKPiArCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkgewo+ICsJCXZhbCA9IEk5 MTVfUkVBRChFRFBfUFNSMl9DVEwpOwo+ICsJCVdBUk5fT04oISh2YWwgJiBFRFBfUFNSMl9FTkFC TEUpKTsKPiArCQlJOTE1X1dSSVRFKEVEUF9QU1IyX0NUTCwgdmFsICYgfkVEUF9QU1IyX0VOQUJM RSk7Cj4gKwl9IGVsc2Ugewo+ICsJCXZhbCA9IEk5MTVfUkVBRChFRFBfUFNSX0NUTCk7Cj4gKwkJ V0FSTl9PTighKHZhbCAmIEVEUF9QU1JfRU5BQkxFKSk7Cj4gKwkJSTkxNV9XUklURShFRFBfUFNS X0NUTCwgdmFsICYgfkVEUF9QU1JfRU5BQkxFKTsKPiArCX0KPiArCWRldl9wcml2LT5wc3IuYWN0 aXZlID0gZmFsc2U7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkCj4gIGludGVsX3Bzcl9kaXNhYmxl X3NvdXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7Cj4gQEAgLTY2NiwyMCArNjg1 LDE0IEBAIGludGVsX3Bzcl9kaXNhYmxlX3NvdXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw KQo+ICAJCWk5MTVfcmVnX3QgcHNyX3N0YXR1czsKPiAgCQl1MzIgcHNyX3N0YXR1c19tYXNrOwo+ IAo+ICsJCWludGVsX3Bzcl9leGl0KGRldl9wcml2KTsKPiArCj4gIAkJaWYgKGRldl9wcml2LT5w c3IucHNyMl9lbmFibGVkKSB7Cj4gIAkJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVM7Cj4g IAkJCXBzcl9zdGF0dXNfbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOwo+IC0KPiAt CQkJSTkxNV9XUklURShFRFBfUFNSMl9DVEwsCj4gLQkJCQkgICBJOTE1X1JFQUQoRURQX1BTUjJf Q1RMKSAmCj4gLQkJCQkgICB+KEVEUF9QU1IyX0VOQUJMRSB8IEVEUF9TVV9UUkFDS19FTkFCTEUp KTsKPiAtCj4gIAkJfSBlbHNlIHsKPiAgCQkJcHNyX3N0YXR1cyA9IEVEUF9QU1JfU1RBVFVTOwo+ ICAJCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+IC0KPiAt CQkJSTkxNV9XUklURShFRFBfUFNSX0NUTCwKPiAtCQkJCSAgIEk5MTVfUkVBRChFRFBfUFNSX0NU TCkgJiB+RURQX1BTUl9FTkFCTEUpOwo+ICAJCX0KPiAKPiAgCQkvKiBXYWl0IHRpbGwgUFNSIGlz IGlkbGUgKi8KPiBAQCAtNjg3LDggKzcwMCw2IEBAIGludGVsX3Bzcl9kaXNhYmxlX3NvdXJjZShz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJCQkJCSAgICBwc3Jfc3RhdHVzLCBwc3Jfc3Rh dHVzX21hc2ssIDAsCj4gIAkJCQkJICAgIDIwMDApKQo+ICAJCQlEUk1fRVJST1IoIlRpbWVkIG91 dCB3YWl0aW5nIGZvciBQU1IgSWRsZSBTdGF0ZVxuIik7Cj4gLQo+IC0JCWRldl9wcml2LT5wc3Iu YWN0aXZlID0gZmFsc2U7Cj4gIAl9IGVsc2Ugewo+ICAJCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJf ZW5hYmxlZCkKPiAgCQkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKSAmIEVEUF9QU1Iy X0VOQUJMRSk7Cj4gQEAgLTkyNiwyNSArOTM3LDYgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX3dv cmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ cHNyLmxvY2spOwo+ICB9Cj4gCj4gLXN0YXRpYyB2b2lkIGludGVsX3Bzcl9leGl0KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtewo+IC0JdTMyIHZhbDsKPiAtCj4gLQlpZiAo IWRldl9wcml2LT5wc3IuYWN0aXZlKQo+IC0JCXJldHVybjsKPiAtCj4gLQlpZiAoZGV2X3ByaXYt PnBzci5wc3IyX2VuYWJsZWQpIHsKPiAtCQl2YWwgPSBJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKTsK PiAtCQlXQVJOX09OKCEodmFsICYgRURQX1BTUjJfRU5BQkxFKSk7Cj4gLQkJSTkxNV9XUklURShF RFBfUFNSMl9DVEwsIHZhbCAmIH5FRFBfUFNSMl9FTkFCTEUpOwo+IC0JfSBlbHNlIHsKPiAtCQl2 YWwgPSBJOTE1X1JFQUQoRURQX1BTUl9DVEwpOwo+IC0JCVdBUk5fT04oISh2YWwgJiBFRFBfUFNS X0VOQUJMRSkpOwo+IC0JCUk5MTVfV1JJVEUoRURQX1BTUl9DVEwsIHZhbCAmIH5FRFBfUFNSX0VO QUJMRSk7Cj4gLQl9Cj4gLQlkZXZfcHJpdi0+cHNyLmFjdGl2ZSA9IGZhbHNlOwo+IC19Cj4gLQo+ ICAvKioKPiAgICogaW50ZWxfcHNyX2ludmFsaWRhdGUgLSBJbnZhbGlkYWRlIFBTUgo+ICAgKiBA ZGV2X3ByaXY6IGk5MTUgZGV2aWNlCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK