Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A222C433EF for ; Mon, 3 Jan 2022 16:36:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D9F9B804C8; Mon, 3 Jan 2022 17:36:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 63D0280605; Mon, 3 Jan 2022 17:36:08 +0100 (CET) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BEB3A80384 for ; Mon, 3 Jan 2022 17:36:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=heiko@sntech.de Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4QJQ-0000Do-UD; Mon, 03 Jan 2022 17:35:56 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, Quentin Schulz Cc: cmuellner@linux.com, u-boot@lists.denx.de Subject: Re: [PATCH] arm: dts: rk3399-puma: re-add vdd_log for uboot Date: Mon, 03 Jan 2022 17:35:55 +0100 Message-ID: <20483056.VYsA4NHGNW@diego> In-Reply-To: <56e7f480-c9af-60e5-6964-037cbcec7555@theobroma-systems.com> References: <20211226124544.1231936-1-heiko@sntech.de> <56e7f480-c9af-60e5-6964-037cbcec7555@theobroma-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Quentin, Am Montag, 3. Januar 2022, 13:26:09 CET schrieb Quentin Schulz: > Hi Heiko, > > On 12/26/21 13:45, Heiko Stuebner wrote: > > The rk3399-puma board needs a 950mV vdd_log to work stable. > > This was already added in > > commit 77012e79ffc3 ("rockchip: rk3399-puma: Set VDD_LOG to 950 mV") > > but lost again with > > commit 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux") > > > > So to make puma stable again re-add the vdd_log pwm regulator. > > As it is not part of the mainline Linux dts right now, add it > > to the -u-boot dtsi for puma. > > > > Fixes: 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux") > > Signed-off-by: Heiko Stuebner > > --- > > arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi b/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi > > index 29846c4b00..76eb51d2d7 100644 > > --- a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi > > +++ b/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi > > @@ -49,6 +49,17 @@ > > regulator-min-microvolt = <1800000>; > > regulator-max-microvolt = <1800000>; > > }; > > + > > + vdd_log: vdd-log { > > + compatible = "pwm-regulator"; > > + pwms = <&pwm2 0 25000 1>; > > + regulator-name = "vdd_log"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1400000>; > > + regulator-always-on; > > + regulator-boot-on; > > + regulator-init-microvolt = <950000>; > > + }; > > }; > > > > &gpio1 { > > Is this a spurious patch by any chance? yep, I realized that I was on 2021.01 still. Shortly after that the vdd_log was re-added by Christoph. Heiko > > https://source.denx.de/u-boot/u-boot/-/commit/1621afc84f8a109cfdb98c9e370c355289e07870 > seems to have more or less the same content, sent (and merged) about a > year ago by Christoph. > > Moreover, it seems to still be there in master: > https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi#L52-L62 > > Cheers, > Quentin >