From: "flichtenheld (Code Review)" Date: Tue, 9 Jul 2024 13:32:34 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <204abeb47fc95a346c091f36f457648d44fa5a81-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="EveDprq86K4="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: configure: Switch to C11 by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --EveDprq86K4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/673?usp=3Demail to review the following change. Change subject: configure: Switch to C11 by default ...................................................................... configure: Switch to C11 by default Mostly so we can use anonymous structs without jumping through hoops or relying on unofficial support. Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 Signed-off-by: Frank Lichtenheld --- M CMakeLists.txt M configure.ac 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/673/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index f8b37a9..6f8bc72 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -119,7 +119,7 @@ set(OPENVPN_VERSION_PATCH ${PRODUCT_VERSION_PATCH}) set(OPENVPN_VERSION_RESOURCE ${PRODUCT_VERSION_RESOURCE}) -set(CMAKE_C_STANDARD 99) +set(CMAKE_C_STANDARD 11) # Set the various defines for config.h.cmake.in if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux") diff --git a/configure.ac b/configure.ac index 5f72029..de67a08 100644 --- a/configure.ac +++ b/configure.ac @@ -421,10 +421,10 @@ AC_CHECK_PROGS([RST2HTML], [rst2html rst2html.py]) AM_CONDITIONAL([HAVE_PYDOCUTILS], [test "${RST2MAN}" -a "${RST2HTML}"]) -# Set -std=3Dc99 unless user already specified a -std=3D +# Set -std=3Dc11 unless user already specified a -std=3D case "${CFLAGS}" in *-std=3D*) ;; - *) CFLAGS=3D"${CFLAGS} -std=3Dc99" ;; + *) CFLAGS=3D"${CFLAGS} -std=3Dc11" ;; esac # -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/673?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 Gerrit-Change-Number: 673 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --EveDprq86K4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

configure: Switch to C11 by default

Mostly so we can u= se anonymous structs without jumping through
hoops or relying on unoffic= ial support.

Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186Signed-off-by: Frank Lichtenheld <frank@...2641...>
---
M CMak= eLists.txt
M configure.ac
2 files changed, 3 insertions(+), 3 deletio= ns(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/change=
s/73/673/1
diff --git a/CMakeLists.txt b/CMakeLists.txt
<= span>index f8b37a9..6f8bc72 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -119,7 +119,7 @@
set(OPENVPN_VERSION_PATCH ${PRODUCT_VERSION_PATCH})
<= span> set(OPENVPN_VERSION_RESOURCE ${PRODUCT_VERSION_RESOURCE})

<= span>

-set(CMAKE_C_STA= NDARD 99)
+set(CMAKE_= C_STANDARD 11)

# Set the various defines= for config.h.cmake.in
if (${CMAKE_SYSTEM_NAME} STREQUAL &= quot;Linux")
diff --git a/configure.ac b/configure.ac<= /span>
index 5f72029..de67a08 100644
--- a/configu= re.ac
+++ b/configure.ac
@@ -421,10 +421,10= @@
AC_CHECK_PROGS([RST2HTML], [rst2html rst2html.py])
AM_CONDITIONAL([HAVE_PYDOCUTILS], [test "${RST2MAN}"= ; -a "${RST2HTML}"])

-# Set -std=3Dc99 unless user already specified a= -std=3D
+# Set -std= =3Dc11 unless user already specified a -std=3D
case "= ${CFLAGS}" in
*-std=3D*) ;;
- *) CFLAGS=3D"${CFLAGS} -std=3D= c99" ;;
+ *) = CFLAGS=3D"${CFLAGS} -std=3Dc11" ;;
esac

#

To vie= w, visit = change 673. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I72934e747d1ad68a7e3675afbeb= 1b63df7941186
Gerrit-Change-Number: 673
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--EveDprq86K4=--