Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A59C28CBC for ; Wed, 6 May 2020 17:18:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9F4020936 for ; Wed, 6 May 2020 17:18:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="bC3d54JE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F4020936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0E46D177C; Wed, 6 May 2020 19:17:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0E46D177C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588785498; bh=DcJWLXvLlvZQGINW6ddP6KoaVYqK7I8DWUPMtCIs4KA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bC3d54JEi/r0j6Yr6kACStUaMs2VcgsH0myfsf+sZgMr0dm3cLtAbiSy2lbhbrxK/ e6RcVhx5UfYrdB/awl7ecgyYykMX0hG2olBMtp5p/l8w1D06+EjFfRuxm+iK7fFCPB akmo2qljHwofQURJ0x7FguNi+MCDqyAluwk1vlFM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8EC79F800DF; Wed, 6 May 2020 19:17:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A7A70F80249; Wed, 6 May 2020 19:17:25 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2493DF800DF for ; Wed, 6 May 2020 19:17:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2493DF800DF IronPort-SDR: J99daio+VHmk1UTOPVw+ugKqTE+M1VTaRRhBpPbqZCBfPliYnM/16njAIyo+Ywzkhi5o6NzuEH f460jZfP3gnw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 10:17:05 -0700 IronPort-SDR: mmH8gbA2BjBKdjfEAqXJ+Q1LVjhtJ6DpPHTVLaW5EwFCvspgIrJAS4jf3YJj2iVJ7dD+TEnUGn Ti3vx+20J3CQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,360,1583222400"; d="scan'208";a="249824162" Received: from sbhat1-mobl.amr.corp.intel.com (HELO [10.251.3.11]) ([10.251.3.11]) by fmsmga007.fm.intel.com with ESMTP; 06 May 2020 10:17:04 -0700 Subject: Re: [PATCH 14/14] ASoC: amd: enable build for RN machine driver To: Mark Brown , "Mukunda, Vijendar" References: <20200505205327.642282-1-alexander.deucher@amd.com> <20200505205327.642282-15-alexander.deucher@amd.com> <2a8891ec-d162-77ed-8093-6c7072b6b8f7@linux.intel.com> <20200506162656.GH5299@sirena.org.uk> <20200506164345.GI5299@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <2061b12a-cc4b-558f-6fc1-b6bf548e7603@linux.intel.com> Date: Wed, 6 May 2020 12:17:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506164345.GI5299@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Alex Deucher , "tiwai@suse.de" , "alsa-devel@alsa-project.org" , "Deucher, Alexander" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 5/6/20 11:43 AM, Mark Brown wrote: > On Wed, May 06, 2020 at 04:33:00PM +0000, Mukunda, Vijendar wrote: > >>>>> +config SND_SOC_AMD_RENOIR_MACH >>>>> + tristate "AMD Renoir support for DMIC" >>>>> + select SND_SOC_DMIC > >>>> there could be a missing dependency if GPIOLIB is not selected >>> (SND_SOC_DMIC >>>> depends on it). > >>> That dependency is wrong, DMICs don't need GPIOs so while a given system >>> might need DMIC the code should be fine with the stub gpiolib >>> implementation. It will mean it won't work on some boards though. > >> For our current implementation, we don't have any GPIOLIB dependency. >> We just need a generic DMIC driver which should provide codec dai for >> sound card registration. > > What you've got should be fine then, you should test with a !GPIOLIB > build just to be sure though and ideally submit a patch fixing the > SND_SOC_DMIC Kconfig. if you don't care about gpios, then the only reason to use the dmic codec would be the modeswitch and wakeup delays properties. If you don't care then a dummy codec would be just fine.