From: Egbert Eich Subject: Re: [PATCH 07/24] drm/i915: fold the no-irq check into intel_hpd_irq_handler Date: Wed, 12 Jun 2013 16:33:55 +0200 Message-ID: <20920.34515.539602.276112@linux-qknr.site> References: <1371037046-3732-1-git-send-email-daniel.vetter@ffwll.ch> <1371037046-3732-8-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id A07CEE5CB2 for ; Wed, 12 Jun 2013 07:33:57 -0700 (PDT) In-Reply-To: daniel.vetter@ffwll.ch wrote on Wednesday, 12 June 2013 at 13:37:09 +0200 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Egbert Eich , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org Daniel Vetter writes: > The usual pattern for our sub-function irq_handlers is that they check > for the no-irq case themselves. This results in more streamlined code > in the upper irq handlers. > > Cc: Egbert Eich > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_irq.c | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > [reviewed code deleted] Reviewed-by: Egbert Eich