From: Egbert Eich Subject: Re: i915 irq storm mitigation in 3.10 Date: Mon, 22 Jul 2013 22:36:40 +0200 Message-ID: <20973.38872.684689.270371@linux-qknr.site> References: <2b828191fde71b2243f883e2dbb28d6d@hz6.de> <20130708200316.GG18285@phenom.ffwll.local> <20972.59257.635588.597578@linux-qknr.site> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 49BEAE5CCE for ; Mon, 22 Jul 2013 13:36:46 -0700 (PDT) In-Reply-To: jn@hz6.de wrote on Monday, 22 July 2013 at 21:28:33 +0200 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jan Niggemann Cc: Egbert Eich , intel-gfx List-Id: intel-gfx@lists.freedesktop.org Jan Niggemann writes: > Egbert, Daniel, others, > It's a Lenovo ThinkPad T400, the model is 7434-AG2. > root@muretop:~# lspci -n > 00:00.0 0600: 8086:2a40 (rev 07) > 00:02.0 0300: 8086:2a42 (rev 07) Ok, this is a gm45. > > As to the log: I messed up the kernel parameters this morning... was > out of coffee this morning and my 1,5y daughter played around me :-) > > Here's my kernel log with drm.debug and printk.time enabled: > Uncompressed (22M): http://files.hz6.de/kern_20130722.log These logs show that interrupts are still coming thru although they should be disabled. Could you try if the patch below makes any difference? Cheers, Egbert. >From 70dae32e99799d15ddcedd5853514215624a8289 Mon Sep 17 00:00:00 2001 From: Egbert Eich Date: Mon, 22 Jul 2013 22:33:36 +0200 Subject: [PATCH] drm/i915: Make sure PORT_HOTPLUG_EN is written Add posting read to make sure PORT_HOTPLUG_EN is written in i915_hpd_irq_setup(). Signed-off-by: Egbert Eich --- drivers/gpu/drm/i915/i915_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index f708e4e..e43d809 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2802,6 +2802,7 @@ static void i915_hpd_irq_setup(struct drm_device *dev) /* Ignore TV since it's buggy */ I915_WRITE(PORT_HOTPLUG_EN, hotplug_en); + POSTING_READ(PORT_HOTPLUG_EN); } } -- 1.8.1.4