From: Egbert Eich Subject: Re: i915 irq storm mitigation in 3.10 Date: Fri, 26 Jul 2013 07:11:32 +0200 Message-ID: <20978.1284.461861.123213@linux-qknr.site> References: <2b828191fde71b2243f883e2dbb28d6d@hz6.de> <20130708200316.GG18285@phenom.ffwll.local> <20972.59257.635588.597578@linux-qknr.site> <20974.26726.659962.223064@linux-qknr.site> <20976.55523.670477.45248@linux-qknr.site> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A640E5FD4 for ; Thu, 25 Jul 2013 22:11:39 -0700 (PDT) In-Reply-To: jn@hz6.de wrote on Thursday, 25 July 2013 at 23:23:24 +0200 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jan Niggemann Cc: Egbert Eich , intel-gfx List-Id: intel-gfx@lists.freedesktop.org Jan Niggemann writes: > Hi Daniel, > > Am 25.07.2013 11:58, schrieb Daniel Vetter: > > Can you pls try the below > > patch (on top of Egbert's debug stuff)? > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h > > index 6caa748..2d4c884 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -1925,9 +1925,9 @@ > > > > #define PORT_HOTPLUG_STAT (dev_priv->info->display_mmio_offset > > + 0x61114) > > /* HDMI/DP bits are gen4+ */ > > -#define PORTB_HOTPLUG_LIVE_STATUS (1 << 29) > > +#define PORTD_HOTPLUG_LIVE_STATUS (1 << 29) > > #define PORTC_HOTPLUG_LIVE_STATUS (1 << 28) > > -#define PORTD_HOTPLUG_LIVE_STATUS (1 << 27) > > +#define PORTB_HOTPLUG_LIVE_STATUS (1 << 27) > > #define PORTD_HOTPLUG_INT_STATUS (3 << 21) > > #define PORTC_HOTPLUG_INT_STATUS (3 << 19) > > #define PORTB_HOTPLUG_INT_STATUS (3 << 17) > I did, here are the logs: > 364K http://files.hz6.de/kern_20130724_2.log I get a 'forbidden' when I try to access this. > I don't understand what exactly this patch does, but I noticed: > - much less drm debug info, resulting in a much smaller log > - no more noticeable lag on my system (even though a storm was > detected). Ok, so this indicates that the storm detection works now :) > I double checked the latter and the lag seems indeed to be gone... Before we actually masked out individual events it was irrelevant if the bits were mixed up. Now we need to be correct on these. Jan, thanks for your help! Cheers, Egbert.