Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB069C433E0 for ; Thu, 14 Jan 2021 11:49:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F59123A34 for ; Thu, 14 Jan 2021 11:49:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F59123A34 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.66947.119119 (Exim 4.92) (envelope-from ) id 1l017e-0001AI-Th; Thu, 14 Jan 2021 11:49:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 66947.119119; Thu, 14 Jan 2021 11:49:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l017e-0001AB-OY; Thu, 14 Jan 2021 11:49:02 +0000 Received: by outflank-mailman (input) for mailman id 66947; Thu, 14 Jan 2021 11:49:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l017d-00019L-L5 for xen-devel@lists.xenproject.org; Thu, 14 Jan 2021 11:49:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 103aea8e-08e7-4f3d-99aa-b8937373416c; Thu, 14 Jan 2021 11:49:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C25C6B7BE; Thu, 14 Jan 2021 11:48:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 103aea8e-08e7-4f3d-99aa-b8937373416c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610624939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nf4WufskEf/DN3zWXbKBlS4kJGMMkbDMViikUKxyBGc=; b=c3XWPxubtpQF67HcFxGxXpeWHGSr7isIFUp8zD3AC+AipYLutlfZLECOJJcRSXgsd0j33B 5w4xpbJIIf6wVCZhkcbh9ljNcl9eOFPtEcOAiB8FATxLArXEnsL57To8Khea2rvbRHrUWw pjDhCoDGTdypsYWxYxmfZIhFzCtnxDo= Subject: Re: [PATCH] x86/dpci: remove the dpci EOI timer To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , "Cooper, Andrew" , Wei Liu , "Tian, Kevin" References: <20210112173248.28646-1-roger.pau@citrix.com> <20210113131100.p5xiyfgtp5s5rktz@Air-de-Roger> From: Jan Beulich Message-ID: <20dd6c2a-a576-e4ff-53da-88de97c803ed@suse.com> Date: Thu, 14 Jan 2021 12:48:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113131100.p5xiyfgtp5s5rktz@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 13.01.2021 14:11, Roger Pau Monné wrote: > On Wed, Jan 13, 2021 at 06:21:03AM +0000, Tian, Kevin wrote: >>> From: Roger Pau Monne >>> As with previous patches, I'm having a hard time figuring out why this >>> was required in the first place. I see no reason for Xen to be >>> deasserting the guest virtual line. There's a comment: >>> >>> /* >>> * Set a timer to see if the guest can finish the interrupt or not. For >>> * example, the guest OS may unmask the PIC during boot, before the >>> * guest driver is loaded. hvm_pci_intx_assert() may succeed, but the >>> * guest will never deal with the irq, then the physical interrupt line >>> * will never be deasserted. >>> */ >>> >>> Did this happen because the device was passed through in a bogus state >>> where it would generate interrupts without the guest requesting >> >> It could be a case where two devices share the same interrupt line and >> are assigned to different domains. In this case, the interrupt activity of >> two devices interfere with each other. > > This would also seem to be problematic if the device decides to use > MSI instead of INTx, but due to the shared nature of the INTx line we > would continue to inject INTx (generated from another device not > passed through to the guest) to the guest even if the device has > switched to MSI. I'm having trouble with this: How does the INTx line matter when a device is using MSI? I don't see why we should inject INTx when the guest has configured a device for MSI; if we do, this would indeed look like a bug (but aiui we bind either the MSI IRQ or the pin based one, but not both). Jan