From: Ian Jackson Subject: [PATCH] libxl: save/restore errno in SIGCHLD handler Date: Mon, 11 Nov 2013 17:20:28 +0000 Message-ID: <21121.4572.173166.215444@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org Without this, code interrupted by SIGCHLD may experience strange values of errno. (As far as I know this is not the cause of any reported bugs.) This fix should be backported in due course. Signed-off-by: Ian Jackson --- tools/libxl/libxl_fork.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_fork.c b/tools/libxl/libxl_fork.c index 044ddad..b6f0b2d 100644 --- a/tools/libxl/libxl_fork.c +++ b/tools/libxl/libxl_fork.c @@ -157,8 +157,10 @@ int libxl__carefd_fd(const libxl__carefd *cf) static void sigchld_handler(int signo) { + int esave = errno; int e = libxl__self_pipe_wakeup(sigchld_owner->sigchld_selfpipe[1]); assert(!e); /* errors are probably EBADF, very bad */ + errno = esave; } static void sigchld_removehandler_core(void) -- 1.7.10.4