From: Ian Jackson Subject: Re: [PATCH v6 08/12] libxl: ocaml: drop the ocaml heap lock before calling into libxl Date: Thu, 28 Nov 2013 16:40:47 +0000 Message-ID: <21143.29199.417314.857530@mariner.uk.xensource.com> References: <1385507713-347-1-git-send-email-rob.hoes@citrix.com> <1385552627.23112.173.camel@kazak.uk.xensource.com> <360717C0B01E6345BCBE64B758E22C2D197EDE@AMSPEX01CL03.citrite.net> <1385560616.30237.7.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385560616.30237.7.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Dave Scott , Rob Hoes , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [PATCH v6 08/12] libxl: ocaml: drop the ocaml heap lock before calling into libxl"): > On Wed, 2013-11-27 at 13:49 +0000, Rob Hoes wrote: > > This fall into the "copying ocaml values to C before dropping the > > ocaml lock" category: it avoids calling the aohow_val function inside > > the argument list of the libxl functions, which are called without the > > ocaml lock. > > I see, I'd have done it with stack_ao_how and *ao_how as the return > value rather than dynamic allocation but OK. I don't think this change is actually logically interconnected with the locking changes. See my other mail just sent. Ian.