From: Ian Jackson Subject: Re: [PATCH 08/23] libxl: events: Provide libxl__xswait_* Date: Thu, 19 Dec 2013 17:30:04 +0000 Message-ID: <21171.11548.712101.995533@mariner.uk.xensource.com> References: <1387305337-15355-1-git-send-email-ian.jackson@eu.citrix.com> <1387305337-15355-9-git-send-email-ian.jackson@eu.citrix.com> <1387458330.9925.67.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1387458330.9925.67.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Shriram Rajagopalan , George Dunlap , xen-devel@lists.xensource.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [PATCH 08/23] libxl: events: Provide libxl__xswait_*"): > On Tue, 2013-12-17 at 18:35 +0000, Ian Jackson wrote: > > +/*----- xswait: wait for a xenstore node to be suitable -----*/ > > + * If you are satisfied, you MUST call libxl__xswait_stop. > > + * Otherwise, xswait will continue waiting and watching and > > + * will call you back later. > > + * > > + * rc==ETIMEDOUT > > Isn't rc actual a libxl error and hence ERROR_TIMEDOUT? Err, yes. > > + * > > + * The specified timeout was reached. > > + * This has NOT been logged (except to the debug log). > > + * xswait will not continue (but calling libxl__xswait_stop is OK). > > + * > > + * rc!=0 > > also != E{,RROR_}TIMEDOUT Both will be fixed in v2. Ian.