Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA2B4C43334 for ; Tue, 14 Jun 2022 02:25:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E85F484498; Tue, 14 Jun 2022 04:25:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="gWLQlw62"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5EF908449A; Tue, 14 Jun 2022 04:25:26 +0200 (CEST) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D06484497 for ; Tue, 14 Jun 2022 04:25:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20220614022520epoutp03bf594bd37437e015d038d1f173adcaf8~4W4weDQCY1052310523epoutp03x for ; Tue, 14 Jun 2022 02:25:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20220614022520epoutp03bf594bd37437e015d038d1f173adcaf8~4W4weDQCY1052310523epoutp03x DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1655173520; bh=HGSC6OcT95wqIVBSEd9tR05k6WYwTB5IL0jEARHbaXQ=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=gWLQlw62dZT0DZUfzZoW0agrN4iqA60pYcdutiLer6OpOk43eNKMLDNy92/XcIg4E T8p+9VYpypkaJFTH06Gsp9slxw6+34JmXluQdpafQAdUWksdmnE1BxpXI6gPRgzdjv ECZwyTV4NwepJBFlMLHUeqdqz0pMPNC2suE3WrXo= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20220614022520epcas1p433f17ce471e670f05cbb2e93e965ab9b~4W4wO_QZD1776817768epcas1p4i; Tue, 14 Jun 2022 02:25:20 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.36.133]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LMXMz0ZMsz4x9Pw; Tue, 14 Jun 2022 02:25:19 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id D4.64.10063.E81F7A26; Tue, 14 Jun 2022 11:25:19 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220614022518epcas1p3e15f0b9a9c4e2719eb0d258c4afa189f~4W4u7Kh-l0584705847epcas1p3N; Tue, 14 Jun 2022 02:25:18 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220614022518epsmtrp2294a3381a50c0cc53d3290ed6f559489~4W4u6Zj5Z1812318123epsmtrp28; Tue, 14 Jun 2022 02:25:18 +0000 (GMT) X-AuditID: b6c32a35-1dbff7000000274f-68-62a7f18ec3c7 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id D4.E3.08924.E81F7A26; Tue, 14 Jun 2022 11:25:18 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220614022518epsmtip27c4f9e53c888e49ab6b38b94d3670ad0~4W4uflIKP0680306803epsmtip2I; Tue, 14 Jun 2022 02:25:18 +0000 (GMT) Message-ID: <211e835d-ca7d-5e13-e041-68bb785be11e@samsung.com> Date: Tue, 14 Jun 2022 11:25:18 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mmc: fsl_esdhc: Fix 'Internal clock never stabilised.' error Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Peng Fan , Priyanka Jain , Sinan Akman Cc: u-boot@lists.denx.de From: Jaehoon Chung In-Reply-To: <20220612091241.iaewmyf3srf52wcx@pali> Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupik+LIzCtJLcpLzFFi42LZdlhTX7f/4/Ikg6c5Fgv2nGaz+LHqC6tF 15QVTBZXpi9nt3i7t5PdgdVj06pONo+zd3Ywemx8t4PJ48XpFsYAlqhsm4zUxJTUIoXUvOT8 lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygvUoKZYk5pUChgMTiYiV9O5ui /NKSVIWM/OISW6XUgpScAtMCveLE3OLSvHS9vNQSK0MDAyNToMKE7IwPz2awFRwVqWib1MHY wHhcoIuRg0NCwERiR5N4FyMXh5DADkaJCTM/sUI4nxgl9n49ygThfGaUeHhqC1sXIydYx4EP W1kgErsYJb7Nvs8I4bxnlPi0ay07SBWvgJ3Ey97tYDaLgKrEgr0fmCHighInZz5hAbFFBSIk Vra+AbOFBYIlfr/4BLaBWUBc4taT+WCrRQRmMUrs272XGSIhIbHk0H1WEJtNQEdi+7fjTCA2 p4CxRN/fA1DN8hLNW2czgzRLCDRySHyf94cZ4m4Xidvn50DZwhKvjm9hh7ClJD6/28sG0dDM KLF0yUFWCKeHUeJfw3Wor40l9i+dzAQKM2YBTYn1u/QhwooSO3/PZYTYzCfx7msPKyRYeSU6 2oQgSlQkLr1+yQSz6+6T/1AlHhJdF2QnMCrOQgqXWUj+n4XknVkIexcwsqxiFEstKM5NTy02 LDCER3dyfu4mRnCi1DLdwTjx7Qe9Q4xMHIyHGCU4mJVEeCdfXJYkxJuSWFmVWpQfX1Sak1p8 iNEUGDsTmaVEk/OBqTqvJN7QxNLAxMzI2MTC0MxQSZx31bTTiUIC6YklqdmpqQWpRTB9TByc Ug1MeQnXXbcWzfAXE4i76rPC7NAFW6V52wI3lBw6ueHVD4Yr2j3c85XuVsXlTw4KSrMSPWRg vbf5QGS4zMndXeHyptlfhfd9bDnLHb2R59U2/YUZW1WeOwq45sfXTJxWqSO/zuHJ0rSt7JK3 yu1TM5s45mtt9ldkjwjNf7L2Vv+qVZr5EbYXYlxNLVmsolNCbgbumv0xnff+Tz2jKwo7f5Sb +/zfnePKMOfO5xe/Cn7qx1xgU2RflMk+O+ytXGO9kLyfpN6MhJ29V99wzQ9Lf+FWYr59j/RZ o03nBJqW+93Qejq3/rOA+wnj00dX1L2qaD85iXX2gw3fXGR6ry2rLW16+lMukuu15Sc+J7Ue m7lKLMUZiYZazEXFiQDkLZ78HQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsWy7bCSvG7fx+VJBvsXqVss2HOazeLHqi+s Fl1TVjBZXJm+nN3i7d5OdgdWj02rOtk8zt7Zweix8d0OJo8Xp1sYA1iiuGxSUnMyy1KL9O0S uDI+PJvBVnBUpKJtUgdjA+NxgS5GTg4JAROJAx+2snQxcnEICexglPjY8owJIiEl8fnpVLYu Rg4gW1ji8OFiiJq3jBKPVy9kAanhFbCTeNm7nR3EZhFQlViw9wMzRFxQ4uTMJ2A1ogIREp+W TWAFsYUFgiV+v/jEBmIzC4hL3HoynwlkqIjALEaJSbcPskMkJCSWHLrPCrFtA6PEp0dXwCax CehIbP92HOw6TgFjib6/B8CuYxZQl1g/TwiiV16ieets5gmMQrOQ3DELyb5ZCB2zkHQsYGRZ xSiZWlCcm55bbFhglJdarlecmFtcmpeul5yfu4kRHBlaWjsY96z6oHeIkYmD8RCjBAezkgjv 5IvLkoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzXug6GS8kkJ5YkpqdmlqQWgSTZeLglGpgmimR I6J9/VW6MdObiaeenFjUdknUfqdGTVefU8/hJwcf9mS5zZxSZp7nlxJ76br+0zbZlR5PWt5F bTkbwe30rOWdU/DzeVN2TZ1hyO1/ZZOrk/Pi0qkhfz7y3j69u/X8psjDf2XCPn/M/jfbr3Of SuvH+f8/Tdu2juHLyZ5LDvbfFfqkNbPzIxc/O3z8qunDRI4LvX/D9Lw4679+/6ISe2vXG+9/ Fn/mTzAtEL1XnLV4yfa+5xo+P6O9+o4f+Pr3m8DfX0tWBfffcFyocu7NxEVS05JmfVa9w3xn ra7C81+11zb0l666b+7WNGUGL9PR5I8PDXf9mmzVUB/SZMxz/0rXVoee4yL3CrZ0dJQJ1L9T YinOSDTUYi4qTgQAf9W4gfsCAAA= X-CMS-MailID: 20220614022518epcas1p3e15f0b9a9c4e2719eb0d258c4afa189f X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220612091250epcas1p1776f5e3a73015bcfb82fad29efab1bda References: <20220429182734.4281-1-pali@kernel.org> <20220612091241.iaewmyf3srf52wcx@pali> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi, On 6/12/22 18:12, Pali Rohár wrote: > PING? Sorry for too late. > > On Friday 29 April 2022 20:27:34 Pali Rohár wrote: >> Only newer eSDHC controllers set PRSSTAT_SDSTB flag. So do not wait until >> flag PRSSTAT_SDSTB is set on old pre-2.2 controllers. Instead sleep for >> fixed amount of time like it was before commit 6f883e501b65 ("mmc: >> fsl_esdhc: Add emmc hs200 support"). >> >> This change fixes error 'Internal clock never stabilised.' which is printed >> on P2020 board at every access to SD card. >> >> Fixes: 6f883e501b65 ("mmc: fsl_esdhc: Add emmc hs200 support") >> Signed-off-by: Pali Rohár Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung >> --- >> drivers/mmc/fsl_esdhc.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c >> index fdf2cc290e06..3b3587bd8d72 100644 >> --- a/drivers/mmc/fsl_esdhc.c >> +++ b/drivers/mmc/fsl_esdhc.c >> @@ -503,6 +503,7 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock) >> u32 time_out; >> u32 value; >> uint clk; >> + u32 hostver; >> >> if (clock < mmc->cfg->f_min) >> clock = mmc->cfg->f_min; >> @@ -543,6 +544,14 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock) >> >> esdhc_clrsetbits32(®s->sysctl, SYSCTL_CLOCK_MASK, clk); >> >> + /* Only newer eSDHC controllers set PRSSTAT_SDSTB flag */ >> + hostver = esdhc_read32(&priv->esdhc_regs->hostver); >> + if (HOSTVER_VENDOR(hostver) <= VENDOR_V_22) { >> + udelay(10000); >> + esdhc_setbits32(®s->sysctl, SYSCTL_PEREN | SYSCTL_CKEN); >> + return; >> + } >> + >> time_out = 20; >> value = PRSSTAT_SDSTB; >> while (!(esdhc_read32(®s->prsstat) & value)) { >> @@ -562,6 +571,7 @@ static void esdhc_clock_control(struct fsl_esdhc_priv *priv, bool enable) >> struct fsl_esdhc *regs = priv->esdhc_regs; >> u32 value; >> u32 time_out; >> + u32 hostver; >> >> value = esdhc_read32(®s->sysctl); >> >> @@ -572,6 +582,13 @@ static void esdhc_clock_control(struct fsl_esdhc_priv *priv, bool enable) >> >> esdhc_write32(®s->sysctl, value); >> >> + /* Only newer eSDHC controllers set PRSSTAT_SDSTB flag */ >> + hostver = esdhc_read32(&priv->esdhc_regs->hostver); >> + if (HOSTVER_VENDOR(hostver) <= VENDOR_V_22) { >> + udelay(10000); >> + return; >> + } >> + >> time_out = 20; >> value = PRSSTAT_SDSTB; >> while (!(esdhc_read32(®s->prsstat) & value)) { >> -- >> 2.20.1 >> >