From: Heiko Hund Date: Tue, 17 Jul 2012 17:09:34 +0200 Message-ID: <21316332.O9di4uRdZn@...1526...> In-Reply-To: References: <1342533472-30873-1-git-send-email-heiko.hund@...1489...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH] don't treat socket related errors special anymore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alon Bar-Lev Cc: openvpn-devel@lists.sourceforge.net On Tuesday 17 July 2012 17:25:25 Alon Bar-Lev wrote: > Just I don't like the CONNECT_IN_PROGRESS. > I think it is better to rebase first and then submit the > CONNECT_IN_PROGRESS afterwards, I think it would be simpler to just > compare to the two statuses. That would result in either something like if (status == EINPROGRESS #ifdef WIN32 || status == WSAEWOULDBLOCK #endif ) or slightly less disturbing #ifndef WSAEWOULDBLOCK #define WSAEWOULDBLOCK 10035L #endif I do prefer the suggested approach resolving this with configure over these. Or did you have something more attractive in mind? Heiko -- Heiko Hund | Sr. Software Engineer | Tel +49-721-25516-237 | Fax -200 SOPHOS NSG | Amalienbadstr. 41 Bau 52 | 76227 Karlsruhe | Germany