Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F588C7618E for ; Wed, 26 Apr 2023 09:27:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7082E862C5; Wed, 26 Apr 2023 11:27:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="O6UB5D81"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E9D77862C3; Wed, 26 Apr 2023 11:27:01 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 37202862C3 for ; Wed, 26 Apr 2023 11:26:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33Q9QsT6080791; Wed, 26 Apr 2023 04:26:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682501214; bh=7Aab8rRnCOk3L8uwGwzh43b8WpK66scgQH97IIIQE2k=; h=Date:Subject:To:References:From:In-Reply-To; b=O6UB5D81u3OdMXbiVF9WOCXr78tOb3BINRc+gHk+t7oPpwcBe0gQJlpyBb5DuQLya I2pQevWaJxo6AaTnenfX+F0AfSXwpqjqgUSZWhHWTnT60fu8psuBlkAoiypcXgwar2 py93yuzry+bXmJab6NgewPEHdivdUptvJQCGuYys= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33Q9QsVg103942 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Apr 2023 04:26:54 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 26 Apr 2023 04:26:54 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 26 Apr 2023 04:26:54 -0500 Received: from [10.249.131.16] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33Q9QoCe095254; Wed, 26 Apr 2023 04:26:51 -0500 Message-ID: <217dded4-57ba-515f-dec9-77a63aebc303@ti.com> Date: Wed, 26 Apr 2023 14:56:50 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] arch: arm: mach-k3: Delete tifs node in DT fixup Content-Language: en-US To: Udit Kumar , , , , , , References: <20230419061352.3156023-1-u-kumar1@ti.com> <20230420081128.3617214-1-u-kumar1@ti.com> From: Neha Malcom Francis In-Reply-To: <20230420081128.3617214-1-u-kumar1@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Udit On 20/04/23 13:41, Udit Kumar wrote: > This patch deletes tifs DT node as part of fixup. > > TISCI API reported msmc_size, does not include > 64KB reserved size for tifs aka MSMC comms memory. > > As part of fixup, original code uses TISCI API > reported msmc_size as size for sram DT node. > > tifs node is similar to l3-cache, which should > hold address above msms_size, and should be deleted > before passing control to OS. > > Documentation > https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html?highlight=msmc#tisci-msg-query-msmc > > Signed-off-by: Udit Kumar > --- > Changes since v1: > https://lore.kernel.org/all/20230419061352.3156023-1-u-kumar1@ti.com/ > - moved tifs check above l3 as > > arch/arm/mach-k3/common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c > index a2adb791f6..33b1f10d58 100644 > --- a/arch/arm/mach-k3/common.c > +++ b/arch/arm/mach-k3/common.c > @@ -351,6 +351,7 @@ int fdt_fixup_msmc_ram(void *blob, char *parent_path, char *node_name) > subnode, addr, size); > if (addr + size > msmc_size || > !strncmp(fdt_get_name(blob, subnode, &len), "sysfw", 5) || > + !strncmp(fdt_get_name(blob, subnode, &len), "tifs", 4) || > !strncmp(fdt_get_name(blob, subnode, &len), "l3cache", 7)) { > fdt_del_node(blob, subnode); > debug("%s: deleting subnode %d\n", __func__, subnode); Reviewed-by: Neha Malcom Francis I do have a general doubt; why do we have only atf-sram sub-node in msmc_sram in all other devices (j721e, j7200 and am65) except j721s2? -- Thanking You Neha Malcom Francis