Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 261A7C433EF for ; Mon, 14 Mar 2022 08:33:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CAFF83B7D; Mon, 14 Mar 2022 09:32:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=aries-embedded.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aries-embedded.de header.i=@aries-embedded.de header.b="TUeveaY9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 785C783B90; Mon, 14 Mar 2022 09:32:57 +0100 (CET) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3BD9183B74 for ; Mon, 14 Mar 2022 09:32:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=aries-embedded.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wg@aries-embedded.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1647246773; s=strato-dkim-0002; d=aries-embedded.de; h=Date:Message-ID:Subject:From:Cc:To:Cc:Date:From:Subject:Sender; bh=oEzmdiSYtIgWlGk+XYZEBxhjeib9yk8+45ZJPMaUZ9s=; b=TUeveaY9b7vGCau9GWdWt3C9jRuUqqIYEtazB0r0QDwQAMMPbXNCUggLacusROX8gO y8FlBaI0voMENe7Ht+gu72Ol/NbtLrJQ7iGAbKlYR0sYSO3Q+m8xu4zBlajGxqFWXtdN u6QPDfMeCUNcA7A8r0uW+9Q0AQ/jHkC/8lDAOJKJqjjPMkyWsj3uh/5FVZR1ySXJ4/oP wP+nNE5ADaq73o6lyjwF+TPpya9BOOUFY3whLLtDfEEw+CLKxfOu3NUE4G/YYd85HB3H bLxNtb0bLAglEjSl31v6IC1DXMWQETbfWyhhVj8OW8EOsFdi/l5BJ3GMNFCRteOPEtR5 Ub5w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":O2skdFKhfuz21dw9Xid368n6nTAlVRCUfGlb9GDbxEjgBCc0vcCXFl8k0xtDyT9i/awl0z6KPCRF+Aq6dBxQBdhxpSb1vmN9qzmhV9ae" X-RZG-CLASS-ID: mo01 Received: from [IPv6:2001:a61:b9a:3901:c97b:d219:5fe9:1e69] by smtp.strato.de (RZmta 47.40.1 AUTH) with ESMTPSA id Jf1771y2E8Wr3Oa (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) (Client did not present a certificate); Mon, 14 Mar 2022 09:32:53 +0100 (CET) To: U-Boot Mailing List Cc: Marek Vasut From: Wolfgang Grandegger Openpgp: preference=signencrypt Autocrypt: addr=wg@aries-embedded.de; prefer-encrypt=mutual; keydata= mQINBFqyI/MBEADDDS3443M3DyW2bnLyHyTfo0MH07GMXyQlIFzlN/CVjrlah0zGfUbJAw14 WNIh84nrAGq633ppilLaaIOvSftCALcmTQRVacZqY6Nu72p6KidLjJWMfWPlrnfb1wWxG4VK HoxW65Tgilu8l0HixuTkVJCEO2Bh+6exrqKOA12VIJE8NUHIBY9MqaHi77K7rnPzal6ao1Eo f1Wt7gbVLrCs+ycyIAmPpVhL6oP2qRJghSToJXkBEhCcqFmcKPgkK2/VCGLyOgUp5eX9WoyO xGWTdvdhIUXJgLXmJZ56wbnLQdkmPYM9hhgfueXEm/xJ12u/DBM0JIanfzy0EsWeokR2meNu FyW8cO8xvEylzvdC942dB4WemzRddWC/3dEl7Ipfwd90VaYenvtoFNd804oIyD9ytlwbX0vc Rym8HFHnXlUZrFV1wrn5o+W8W82fmFlNG29jOs0ieaLC6gZiHDZhnPcGgYayw941JK2/zZF8 VEGghltgplk5K62DH96GYVHYnagNlQsv18/KfV6S3C7KpA7UhsvAicHSrHFCw3tc2LcEP+ek ngUrPRbXaJb39sdOudRevb2kLR7vdcnJoB1tL9H3e7mom2yws7Gv8qnDkih7kAT5a7PfY7j0 vaXPyynA/T6BPmUQG5xJsksvJtV0/JlK5oaob81+B6DIpN4GtwARAQABtCpXb2xmZ2FuZyBH cmFuZGVnZ2VyIDx3Z0Bhcmllcy1lbWJlZGRlZC5kZT6JAj8EEwECACkFAlqyI/MCGyMFCQlm AYAHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB2wBul+9Uiy5foD/95VrAZq1t1K7Kt p3K7MUsBGVNYY3SrnBFahL1j+oRjbAL/Zl6m9m6Uyd7Ry2bPAIrDEk5Tiwf6AuJHKIlBCl25 LsE6S0Ri2jQ31c74JExZegBxP5BZxPNnQQURYrv7r80tBa6ELOeIv2GCihfcb4BXyt6HvizI jH2idQMtimxau/VhLyHNAa6V4JVjhvR+K5CmCG3Ggj7f6jNesq8fDAZAqs1LwWCpFMHmtb6T vQ9hVIU1/uTPlxlpBeG7tsf273d7Sbau2E3/CO3rQHCja9WfhyWfnBWSzpEFBWEVmZlhA9fO 3K7x9XyEGAVb5OOWsCloakM7tQnA3t56RiqCgrTA4NPJSvu3p7Rci3g8FTBoIn+TkIHM1GdL nMeXwugCdXs5Py0OTEHP2gGsaQrufWOzViWRKhdvsic/HTsmE/FQt/CDeeWCFrAO0iCSn4kd BzlZp+sx6OyImi/cjtCfOeeoqTFJvGvpA1xUJO2xG03HxFVoy+kqTjAxmf7p1cHJHaJar6CT KFwxHvqPQopHpIJQRem+tASOUIf/HxedhD1Zl+cguIG7dm8xL0AtGDtIhHk8Y76wi+4zKVCD 4HbWw6j9pigS8lm9qHVW7rfgRjeS7vruw90NS66OI9OfhQqDyPjhzk58k6PsIwc9YcV+JjJ3 nAKpdf9bE+Re6vooCem/y7kCDQRasiPzARAAyjdO4/vK6KohWRO1ZqocbAbXNzOV9S9Y0ZKU AI9uEXEAsq1AHO/eF52eYrn1tWMaysM/ppcrR2VQqfX9LBhbIqg0eGoIjgxOpZCs1vD2ZmEe aJ2HJxhHTv97lP6iWUC7X2KYsF8pqlTSEKI73v0Rp9tRxoasGicnUOrLGNHtgjsaPMVH9D43 E73K1TVZQsyMXgWvGJH1UfVReszd0KjdTYmzUnJTgS1RUBrNuXeLjWJ2m514+OPN2zhq65Ju 3+K6tGLI2g/eEZcEOvIXNzi8l6GDIJM6IzJRqcfRr/LsBPhwDbfPk/gy5h8a+jf1k63ml4Q+ UEZ9Czk4CLrTasv5E93+3x8a3Oov1Eo/dXScAUl5rVdgFqF2nostseLdufn7yLGH54XTpw5Q FXPqDhASJ9pGUWnvAEitS7LrmxkaMkbMxSbFzzCmDrSaB0vvsvkUGYk7u8ZoCHR62swzGA8e lYPLVJ43lI1ZvEYCwYMorFTwADEWj8rhp2MqwOala5VtLfHbVvbZ0gH1HMDhvaUjgOUBVfzL N2ctrWZxnt8MfbCT1l6HnF2FXk703pk2JVpQROe4oGxMencTy9WubkZMGykkRnvulgmPQ80Y hGECK5utw+RT6sFANFpBbUCCCFT3JPNpZYTIKd17cVZAM6/VHx/LkB+3lzUwQoK+9nXFJZ8A EQEAAYkCJQQYAQIADwUCWrIj8wIbDAUJCWYBgAAKCRB2wBul+9Uiy+cOEAC7EINejlJ9M0zv NN/DweoVYpvJyV3TUOs4R007cr3IuMadyjrCDj3btUqPpzjtOy0yPS/Yw3I8gParqcgBkSbH /SU7E/vsR6X6aY2FeVOi20uhIHL/UZzX/QtDQmczIWpRAtQTShlAv91QrwyK1jiAk1DdTwpo 0nA+z1HeUiD4dHcRuvfr/5luFFSMgGiBKyTBDBTUN84jQqtTqWiBJOZt8RDtrPOc2uMLS652 8RRvHTdIriG2TZAUUGpYEIoqxMIVvpwLBas6Gdsb3z/PKa3dPtIBMlFRIBtBLPSKH1XjBvJz FIZzeG5S3vt3Yd4YL07H2NY6H1mgWldCO+dHAgg52ScR3rpusy03w4IcsX7Koi4kQywHVA1V MD5mtLZH7RdM4pbRlmAnMW0c7tZSYhIjx2E7X0u118aqKWazfSyMRx6f+vmJemV1CQ+FnrZA M50nneCOIRAmu1dJ7d3T2eQtaNjDfHAfH+EZiDLGnUd0gIJ6hkoHbjN2zpvdbP99eWaztLDo C3MBo2NM+l0YjeV18MMJXB+1pxfhYr9M4cEG0hdWZ7WPfLnNzg1F9wAXzbiGP0/voEjjdgEi 1SgfvB+7jLQBb52U9wG7hmA1gS1nkvfGfJZ8Ii7F9GPrpNYQVLAZbQGXGArNsMtMLE9e3CgN caP9sHg88B9851WpveNE6Q== Subject: [PATCH v3] usb: dwc2: handle return code of dev_read_size() in of to, plat function Message-ID: <21c5ee70-bb4a-eeca-8afe-b2b3719d4c4f@aries-embedded.de> Date: Mon, 14 Mar 2022 09:32:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean dev_read_size() returns -EINVAL (-22) if the property "g-tx-fifo-size" does not exist. If that's the case, we now keep the default value of 0. Signed-off-by: Wolfgang Grandegger --- Changes since v2: - fix compiler error using latest U-Boot version Changes since v1: - removed unrelated changes (missing empty line) - improved commit message drivers/usb/gadget/dwc2_udc_otg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/dwc2_udc_otg.c b/drivers/usb/gadget/dwc2_udc_otg.c index 2748270ad6..77988f78ab 100644 --- a/drivers/usb/gadget/dwc2_udc_otg.c +++ b/drivers/usb/gadget/dwc2_udc_otg.c @@ -996,8 +996,9 @@ static int dwc2_udc_otg_of_to_plat(struct udevice *dev) plat->rx_fifo_sz = dev_read_u32_default(dev, "g-rx-fifo-size", 0); plat->np_tx_fifo_sz = dev_read_u32_default(dev, "g-np-tx-fifo-size", 0); - plat->tx_fifo_sz_nb = - dev_read_size(dev, "g-tx-fifo-size") / sizeof(u32); + ret = dev_read_size(dev, "g-tx-fifo-size"); + if (ret > 0) + plat->tx_fifo_sz_nb = ret / sizeof(u32); if (plat->tx_fifo_sz_nb > DWC2_MAX_HW_ENDPOINTS) plat->tx_fifo_sz_nb = DWC2_MAX_HW_ENDPOINTS; if (plat->tx_fifo_sz_nb) { -- 2.28.0