From: "flichtenheld (Code Review)"
Date: Thu, 22 Jan 2026 15:15:54 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <21dcb5e3f43377e745a445018dca14018afc7078-EmailReplacePatchSet-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="bH9WUQgHP/0="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: Update mbedtls
to v4
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--bH9WUQgHP/0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, uddr,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1474?usp=3Demail
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied=
now.
Change subject: GHA: Update mbedtls to v4
......................................................................
GHA: Update mbedtls to v4
Also switch from Make to CMake for building it
because the former is not supported anymore.
Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Signed-off-by: Frank Lichtenheld
---
M .github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1474/2
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d1322c7..ef9b3f5 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -366,12 +366,12 @@
- name: make check
run: make -j3 check VERBOSE=3D1
- mbedtls3:
+ mbedtls4:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04]
- ssllib: [mbedtls3]
+ ssllib: [mbedtls4]
build: [ normal, asan ]
include:
- build: asan
@@ -398,15 +398,19 @@
uses: actions/checkout@...2977... # v6.0.1
with:
path: mbedtls
- submodules: true
+ submodules: recursive
# versioning=3Dsemver-coerced
repository: Mbed-TLS/mbedtls
- ref: v3.6.5
- - name: "mbedtls: make no_test"
- run: make -j3 no_test SHARED=3D1
+ ref: v4.0.0
+ - uses: lukka/get-cmake@...2927... # v4.1.1
+ - name: "mbedtls: cmake"
+ run: cmake -B build
working-directory: mbedtls
- - name: "mbedtls: make install"
- run: sudo make install DESTDIR=3D/usr
+ - name: "mbedtls: cmake --build"
+ run: cmake --build build
+ working-directory: mbedtls
+ - name: "mbedtls: cmake --install"
+ run: sudo cmake --install build --prefix /usr
working-directory: mbedtls
- name: Checkout OpenVPN
uses: actions/checkout@...2977... # v6.0.1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: uddr
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
--bH9WUQgHP/0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: flichtenheld, plaisthos.
flichtenheld uploaded patch set #2 to this change.
<=
p>View C=
hange
The change is no longer submittable: checks~ChecksSubmitRul=
e is unsatisfied now.
GHA: Update mbedtls to v4
Als=
o switch from Make to CMake for building it
because the former is not su=
pported anymore.
Change-Id: I658b1b24da304938225a8f834d7484671a63360=
f
Signed-off-by: Frank Lichtenheld <frank@...2641...>
---
M =
.github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletio=
ns(-)
git pull ssh://gerrit.openvpn.net:29418/op=
envpn refs/changes/74/1474/2
diff --git a/.github/workflows/build.y=
aml b/.github/workflows/build.yaml
index d1322c7..ef9b3f5 1=
00644
--- a/.github/workflows/build.yaml
++=
+ b/.github/workflows/build.yaml
@@ -366,12 +366,12 @@
- name: make check
run: make -j=
3 check VERBOSE=3D1
- mbedtls3:
+ mbedtls4:
strategy:
f=
ail-fast: false
matrix:
os:=
[ubuntu-22.04]
- =
ssllib: [mbedtls3]
=
+ ssllib: [mbedtls4]
build: [ normal, asan =
]
include:
- build: asa=
n
@@ -398,15 +398,19 @@
uses: acti=
ons/checkout@...2977... # v6.0.1
with:
<=
span> path: mbedtls
- submodules: true
+ submodules: recursive
#=
versioning=3Dsemver-coerced
repository: Mbed-TL=
S/mbedtls
- re=
f: v3.6.5
- - name=
: "mbedtls: make no_test"
- run: make -j3 no_test SHARED=3D1
+ ref: v4.0.0
+ - uses: lukka/get-cmake@...2939...=
.. # v4.1.1
+ - =
name: "mbedtls: cmake"
+ run: cmake -B build
working-d=
irectory: mbedtls
- =
- name: "mbedtls: make install"
- run: sudo make install DESTDIR=3D/usr<=
br>+ - name: "mbedtls=
: cmake --build"
+ run: cmake --build build
+ working-directory: mbedtls
+ - name: "mbedtls: cmake --install&=
quot;
+ run: s=
udo cmake --install build --prefix /usr
working-di=
rectory: mbedtls
- name: Checkout OpenVPN
=
uses: actions/checkout@...2977... # v6.0.1
<=
/span>
To view, visit change 1474. To unsubscribe, or for help writ=
ing mail filters, visit settings.
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7=
484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: uddr <yura.uddr@...277...&=
gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
=
--bH9WUQgHP/0=--