Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7C7C4361B for ; Mon, 7 Dec 2020 13:50:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22C51233FA for ; Mon, 7 Dec 2020 13:50:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22C51233FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D64D89D61; Mon, 7 Dec 2020 13:50:49 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2A0D89D61 for ; Mon, 7 Dec 2020 13:50:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 39F72AB63; Mon, 7 Dec 2020 13:50:46 +0000 (UTC) Subject: Re: [PATCH v3 10/13] video: fbdev: gbefb: Fix set but not used warning To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-11-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <21f4d506-04cc-3e51-2001-caea493de809@suse.de> Date: Mon, 7 Dec 2020 14:50:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-11-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones , Geert Uytterhoeven , Michael Ellerman , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Content-Type: multipart/mixed; boundary="===============0599690557==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0599690557== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HmciU3ZxSV6AfntWGwBAddLpBupsAza6h" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HmciU3ZxSV6AfntWGwBAddLpBupsAza6h Content-Type: multipart/mixed; boundary="X8O1oEuHfJsdnJ2i46qP5uyNJ6MqgVzMZ"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: <21f4d506-04cc-3e51-2001-caea493de809@suse.de> Subject: Re: [PATCH v3 10/13] video: fbdev: gbefb: Fix set but not used warning References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-11-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-11-sam@ravnborg.org> --X8O1oEuHfJsdnJ2i46qP5uyNJ6MqgVzMZ Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > The variable "x" was set but never used. > Drop the redundant assignments. >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/gbefb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c > index 31270a8986e8..c5b99a4861e8 100644 > --- a/drivers/video/fbdev/gbefb.c > +++ b/drivers/video/fbdev/gbefb.c > @@ -198,7 +198,7 @@ static void gbe_reset(void) > static void gbe_turn_off(void) > { > int i; > - unsigned int val, x, y, vpixen_off; > + unsigned int val, y, vpixen_off; > =20 > gbe_turned_on =3D 0; > =20 > @@ -249,7 +249,6 @@ static void gbe_turn_off(void) > =20 > for (i =3D 0; i < 100000; i++) { > val =3D gbe->vt_xy; > - x =3D GET_GBE_FIELD(VT_XY, X, val); > y =3D GET_GBE_FIELD(VT_XY, Y, val); > if (y < vpixen_off) > break; > @@ -260,7 +259,6 @@ static void gbe_turn_off(void) > "gbefb: wait for vpixen_off timed out\n"); > for (i =3D 0; i < 10000; i++) { > val =3D gbe->vt_xy; > - x =3D GET_GBE_FIELD(VT_XY, X, val); > y =3D GET_GBE_FIELD(VT_XY, Y, val); > if (y > vpixen_off) > break; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --X8O1oEuHfJsdnJ2i46qP5uyNJ6MqgVzMZ-- --HmciU3ZxSV6AfntWGwBAddLpBupsAza6h Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/OMzQFAwAAAAAACgkQlh/E3EQov+AW 0hAA0DGijVeuGk2118333CrQPBB7RUYqE8ksHoiE2OzbIJAei+mOL9vD934bsRHz/9I+gwUVyOSX vWgzQU8YdJLwGFJSR9ZE6K6X80Z+upb3Pb/NH1wTnWlks87WWp3schCMWDl+0S1OSdNlIECaSN16 k5tsGorxy62ySjwTV+fBRbgIsX8EC0jSfDcDc2QtRiXlYxIsFneKM3C1LrGWWNkbM3U3OR5d0DbN 65xVpfB8ASzsdiVj4ib8jYOsow9lUz5Gln8DekQPZFtXZwpxRGMe+1GrqztXP2MKXQf+V7OU6gbm AfYuQg2N3AkljgzNcrMMfRuD0FY5kSvju6cjiuLQEAYtQ39a3BRFrs5sJmJpxjHY0J1NlGSwRUwS NduUhRbZNmgD4gT6t0dkaS59n/hnjVzA0aLLP5Ccb2t2w/aTSG6hq93ccZYwYXv9Luc0dzn05Kqa ZKTG2SI0lRQLveMEohdU7AnVBtjER7UqZU2dytNAmljjVxCKR4smJ0V9EPOgO3W16z1G4U+Fi9Nx 1j0jWVMqq7JZMmRG0bEutRUvI2Se76aPYF6G/ppwibFno0W5ji+EL5/iraQB+BEVQW29ZTyLTpFQ LmTA0huUIs2BcAjPaKgG6baFrYOW0CKKKVU+NND/gzCR+LWPkpzl1WJFT35R7IKKD5vR/yBkEhKV jWk= =jPXz -----END PGP SIGNATURE----- --HmciU3ZxSV6AfntWGwBAddLpBupsAza6h-- --===============0599690557== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0599690557==--