From: Ian Jackson Subject: Re: [PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on migration fd and reinstate afterwards Date: Fri, 11 Sep 2015 11:50:14 +0100 Message-ID: <22002.45542.20329.665860@mariner.uk.xensource.com> References: <1441968171-15844-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441968171-15844-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, Andrew Cooper , xen-devel@lists.xen.org, Jim Fehlig , Shriram Rajagopalan , Yang Hongyang List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("[PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on migration fd and reinstate afterwards"): > The fd passed to us by libvirt for both save and restore has at least > O_NONBLOCK set, which libxl does not expect and therefore fails to > handle any EAGAIN which might arise. Acked-by: Ian Jackson > For 4.6: This fixes migration with libvirt, which I think is worth > doing before the release. Indeed. > For backports: Once "ts-xen-install: Rewrite /etc/hosts to comment out > 127.0.1.1 entry" passes through osstest's pretest gate and has run on > some of the older branches we should then know if this is necessary > for migration v1. Or we could backport it regardless. Let us see what happens. > +int libxl__fd_flags_modify_save(libxl__gc *gc, int fd, > + int mask, int val, int *r_oldflags) > +{ This is very ... comprehensive. Ian.