From: David Howells Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] Date: Fri, 25 Aug 2006 21:18:24 +0100 Message-ID: <22040.1156537104@warthog.cambridge.redhat.com> References: <20060825200455.GA2629@uranus.ravnborg.org> <20060825193658.11384.8349.stgit@warthog.cambridge.redhat.com> <20060825193707.11384.97372.stgit@warthog.cambridge.redhat.com> Cc: David Howells , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:5802 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932236AbWHYUSa (ORCPT ); Fri, 25 Aug 2006 16:18:30 -0400 In-Reply-To: <20060825200455.GA2629@uranus.ravnborg.org> To: Sam Ravnborg Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Sam Ravnborg wrote: > > +ifeq ($(CONFIG_MMU),y) > > +obj-y += bounce.o > > +endif > > CONFIG_MMU is a bool so you can do this much more elegant: > obj-$(CONFIG_MMU) += bounce.o In patch 18/18, this changes to: ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy) So the elegence in the end is irrelevant. David