From: David Howells Subject: Re: [PATCH 06/18] [PATCH] BLOCK: Move extern declarations out of fs/*.c into header files [try #4] Date: Fri, 25 Aug 2006 21:20:02 +0100 Message-ID: <22086.1156537202@warthog.cambridge.redhat.com> References: <20060825200715.GB2629@uranus.ravnborg.org> <20060825193658.11384.8349.stgit@warthog.cambridge.redhat.com> <20060825193712.11384.67875.stgit@warthog.cambridge.redhat.com> Cc: David Howells , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:5803 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932236AbWHYUUH (ORCPT ); Fri, 25 Aug 2006 16:20:07 -0400 In-Reply-To: <20060825200715.GB2629@uranus.ravnborg.org> To: Sam Ravnborg Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Sam Ravnborg wrote: > Why not fsinternal.h to make it explicit this is fs internal stuff. > This makes it a bit more obvious when lookign at the filename isolated. Consistency: warthog>echo */internal.h crypto/internal.h fs/internal.h mm/internal.h warthog>echo */*/internal.h fs/afs/internal.h fs/nfs/internal.h fs/proc/internal.h fs/ramfs/internal.h net/rxrpc/internal.h security/keys/internal.h David