Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C91EC4345F for ; Wed, 1 May 2024 10:32:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 2D7D4C4AF14; Wed, 1 May 2024 10:32:03 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 7B0C1C113CC; Wed, 1 May 2024 10:32:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 7B0C1C113CC Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i53875b01.versanet.de ([83.135.91.1] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s27FU-0002w0-Fq; Wed, 01 May 2024 12:31:40 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= List-Id: To: soc@kernel.org, Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Khuong Dinh , Ray Jui , Scott Branden , Broadcom internal kernel review list , Robert Richter , Chanho Min , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Thierry Reding , Jonathan Hunter , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang , "Rob Herring (Arm)" Cc: linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: Add/fix /memory node unit-addresses Date: Wed, 01 May 2024 12:31:38 +0200 Message-ID: <2235630.taCxCBeP46@diego> In-Reply-To: <20240430191856.874600-2-robh@kernel.org> References: <20240430191856.874600-2-robh@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Dienstag, 30. April 2024, 21:18:54 CEST schrieb Rob Herring (Arm): > '/memory' nodes always have a 'reg' property, and therefore should have > a unit-address with just plain hex (i.e. no commas). Fix all the arm64 > '/memory' nodes. > > It's possible that some bootloader depends on /memory (arm32 ATAG to DT > code does for example). If so, the memory node should be commented with > that requirement. > > Signed-off-by: Rob Herring (Arm) > --- > arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 2 +- > arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +- For the Rockchip boards Reviewed-by: Heiko Stuebner Other rk3368-based boards like the Geekbox and PX5-evb already use the correct memory@0 node names, so it looks like the the bootloaders used on rk3368 don't have special requirements for the node-naming.