From: Daniele Ceraolo Spurio Subject: Re: [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init Date: Fri, 23 Dec 2016 13:19:18 -0800 Message-ID: <223ad7eb-0150-a411-ec78-9701ddcd23d5@intel.com> References: <20161215154708.31521-1-arkadiusz.hiler@intel.com> <20161215154708.31521-5-arkadiusz.hiler@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7844A6E147 for ; Fri, 23 Dec 2016 21:19:19 +0000 (UTC) In-Reply-To: <20161215154708.31521-5-arkadiusz.hiler@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arkadiusz Hiler , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxNS8xMi8xNiAwNzo0NywgQXJrYWRpdXN6IEhpbGVyIHdyb3RlOgo+IExldCBpbnRlbF9n dWNfaW5pdCgpIGZvY3VzIG9uIGRldGVybWluaW5nIGFuZCBmZXRjaGluZyB0aGUgY29ycmVjdAo+ IGZpcm13YXJlLgo+Cj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGludGVsX3Nhbml0aXplX3VjX3Bh cmFtcygpIHRoYXQgaXMgY2FsbGVkIGZyb20KPiBpbnRlbF91Y19pbml0KCkuCj4KPiBUaGVuLCBp ZiB3ZSBoYXZlIEd1Qywgd2UgY2FuIGNhbGwgaW50ZWxfZ3VjX2luaXQoKSBjb25kaXRpb25hbGx5 IGFuZCB3ZQo+IGRvIG5vdCBoYXZlIHRvIGRvIGludGVybmFsIGNoZWNrcy4KPgo+IEl0IGNhbiBi ZSBlYXNpbHkgZXh0ZW5kZWQgdG8gc3VwcG9ydCBIdUMgY2FzZSBhcyB3ZWxsLgo+Cj4gQ2M6IEFu dXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVsLmNvbT4KPiBDYzogSmVmZiBNY0dl ZSA8amVmZi5tY2dlZUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXaW5pYXJza2kgPG1pY2hhbC53 aW5pYXJza2lAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFya2FkaXVzeiBIaWxlciA8YXJr YWRpdXN6LmhpbGVyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX2xvYWRlci5jIHwgMTkgKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91Yy5jICAgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysrKysrLQo+ ICAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IGluZGV4IGI3NmI1NTYuLjBi YjVmZDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRl ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gQEAg LTYxNyw3ICs2MTcsNyBAQCBzdGF0aWMgdm9pZCBndWNfZndfZmV0Y2goc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICB9Cj4KPiAgLyoqCj4gLSAqIGludGVsX2d1Y19pbml0KCkg LSBkZWZpbmUgcGFyYW1ldGVycyBhbmQgZmV0Y2ggZmlybXdhcmUKPiArICogaW50ZWxfZ3VjX2lu aXQoKSAtIGRldGVybWluZSBhbmQgZmV0Y2ggZmlybXdhcmUKPiAgICogQGRldl9wcml2OglpOTE1 IGRldmljZSBwcml2YXRlCj4gICAqCj4gICAqIENhbGxlZCBlYXJseSBkdXJpbmcgZHJpdmVyIGxv YWQsIGJ1dCBhZnRlciBHRU0gaXMgaW5pdGlhbGlzZWQuCj4gQEAgLTYzMCwxNyArNjMwLDYgQEAg dm9pZCBpbnRlbF9ndWNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IAlzdHJ1Y3QgaW50ZWxfZ3VjX2Z3ICpndWNfZncgPSAmZGV2X3ByaXYtPmd1Yy5ndWNfZnc7Cj4g IAljb25zdCBjaGFyICpmd19wYXRoOwo+Cj4gLQlpZiAoIUhBU19HVUMoZGV2X3ByaXYpKSB7Cj4g LQkJaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcgPSAwOwo+IC0JCWk5MTUuZW5hYmxlX2d1Y19zdWJt aXNzaW9uID0gMDsKPiAtCX0gZWxzZSB7Cj4gLQkJLyogQSBuZWdhdGl2ZSB2YWx1ZSBtZWFucyAi dXNlIHBsYXRmb3JtIGRlZmF1bHQiICovCj4gLQkJaWYgKGk5MTUuZW5hYmxlX2d1Y19sb2FkaW5n IDwgMCkKPiAtCQkJaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcgPSBIQVNfR1VDX1VDT0RFKGRldl9w cml2KTsKPiAtCQlpZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPCAwKQo+IC0JCQlpOTE1 LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IEhBU19HVUNfU0NIRUQoZGV2X3ByaXYpOwo+IC0JfQo+ IC0KPiAgCWlmICghSEFTX0dVQ19VQ09ERShkZXZfcHJpdikpIHsKPiAgCQlmd19wYXRoID0gTlVM TDsKPiAgCX0gZWxzZSBpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikpIHsKPiBAQCAtNjYzLDEzICs2 NTIsNyBAQCB2b2lkIGludGVsX2d1Y19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiAgCWd1Y19mdy0+Z3VjX2Z3X2ZldGNoX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9OT05F Owo+ICAJZ3VjX2Z3LT5ndWNfZndfbG9hZF9zdGF0dXMgPSBHVUNfRklSTVdBUkVfTk9ORTsKPgo+ IC0JLyogY2FuJ3QgZW5hYmxlIGd1YyBzdWJtaXNzaW9uIHdpdGhvdXQgZ3VjICovCj4gLQlpZiAo IWk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nKQo+IC0JCWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9u ID0gMDsKPiAtCj4gIAkvKiBFYXJseSAoYW5kIHNpbGVudCkgcmV0dXJuIGlmIEd1QyBsb2FkaW5n IGlzIGRpc2FibGVkICovCj4gLQlpZiAoIWk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nKQo+IC0JCXJl dHVybjsKPiAgCWlmIChmd19wYXRoID09IE5VTEwpCj4gIAkJcmV0dXJuOwo+ICAJaWYgKCpmd19w YXRoID09ICdcMCcpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vj LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gaW5kZXggNGUxODRlZGIuLmU3 MmY3ODQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiBAQCAtMjUsNiArMjUsMjQgQEAK PiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICNpbmNsdWRlICJpbnRlbF91Yy5oIgo+Cj4gK3N0 YXRpYyB2b2lkIGludGVsX3Nhbml0aXplX3VjX3BhcmFtcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gK3sKPiArCWlmICghSEFTX0dVQyhkZXZfcHJpdikpIHsKPiArCQlpOTE1 LmVuYWJsZV9ndWNfbG9hZGluZyA9IDA7Cj4gKwkJaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24g PSAwOwo+ICsJfSBlbHNlIHsKPiArCQkvKiBBIG5lZ2F0aXZlIHZhbHVlIG1lYW5zICJ1c2UgcGxh dGZvcm0gZGVmYXVsdCIgKi8KPiArCQlpZiAoaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcgPCAwKQo+ ICsJCQlpOTE1LmVuYWJsZV9ndWNfbG9hZGluZyA9IEhBU19HVUNfVUNPREUoZGV2X3ByaXYpOwo+ ICsJCWlmIChpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA8IDApCj4gKwkJCWk5MTUuZW5hYmxl X2d1Y19zdWJtaXNzaW9uID0gSEFTX0dVQ19TQ0hFRChkZXZfcHJpdik7Cj4gKwl9Cj4gKwo+ICsJ LyogY2FuJ3QgZW5hYmxlIGd1YyBzdWJtaXNzaW9uIHdpdGhvdXQgZ3VjICovCj4gKwlpZiAoIWk5 MTUuZW5hYmxlX2d1Y19sb2FkaW5nKQo+ICsJCWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uID0g MDsKPiArfQo+ICsKPiAgdm9pZCBpbnRlbF91Y19pbml0X2Vhcmx5KHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJbXV0ZXhfaW5pdCgmZGV2X3ByaXYtPmd1Yy5zZW5k X211dGV4KTsKPiBAQCAtMzIsNyArNTAsMTAgQEAgdm9pZCBpbnRlbF91Y19pbml0X2Vhcmx5KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPgo+ICB2b2lkIGludGVsX3VjX2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlpbnRlbF9ndWNfaW5p dChkZXZfcHJpdik7Cj4gKwlpbnRlbF9zYW5pdGl6ZV91Y19wYXJhbXMoZGV2X3ByaXYpOwoKSWYg d2UgcGxhY2UgaW50ZWxfc2FuaXRpemVfdWNfcGFyYW1zIGluIGludGVsX3Nhbml0aXplX29wdGlv bnMgd2UgY2FuIApoYXZlIHRoZSBwYXJhbWV0ZXJzIHJlc29sdmVkIGVhcmxpZXIgYW5kIHdlIHNo b3VsZCB0aGVyZWZvcmUgYmUgYWJsZSB0byAKdXNlIHRoZW0gdG8gYmV0dGVyIGhhbmRsZSBHdUMt cmVsYXRlZCBkaWZmZXJlbmNlcyBkdXJpbmcgZHJpdmVyIGxvYWQuCgpEYW5pZWxlCgo+ICsKPiAr CWlmIChpOTE1LmVuYWJsZV9ndWNfbG9hZGluZykKPiArCQlpbnRlbF9ndWNfaW5pdChkZXZfcHJp dik7Cj4gIH0KPgo+ICBpbnQgaW50ZWxfdWNfbG9hZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==