From: Heiko Schocher Date: Wed, 30 Sep 2020 07:38:41 +0200 Subject: [PATCH 1/3] i2c: mediatek: add basic driver support In-Reply-To: <20200909060728.5616-2-mingming.lee@mediatek.com> References: <20200909060728.5616-1-mingming.lee@mediatek.com> <20200909060728.5616-2-mingming.lee@mediatek.com> Message-ID: <22a371ad-76d6-ff6d-ded3-2eeea84bb5ab@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello mingming, Am 09.09.2020 um 08:07 schrieb mingming lee: > From: Mingming Lee > > Add MediaTek I2C basic driver > > Signed-off-by: Mingming Lee > --- > drivers/i2c/Kconfig | 9 + > drivers/i2c/Makefile | 1 + > drivers/i2c/mt_i2c.c | 619 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 629 insertions(+) > create mode 100644 drivers/i2c/mt_i2c.c Nitpicks only: As you introduce here new DTS bindings, can you please document them in u-boot:/doc/device-tree-bindings/ Thanks! [snip] > diff --git a/drivers/i2c/mt_i2c.c b/drivers/i2c/mt_i2c.c > new file mode 100644 > index 0000000..5badde9 > --- /dev/null > +++ b/drivers/i2c/mt_i2c.c > @@ -0,0 +1,619 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * MediaTek I2C Interface driver > + * > + * Copyright (C) 2020 MediaTek Inc. > + * Author: Mingming Lee > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define I2C_OK 0 > +#define EINVAL_I2C 22 /* invalid argument */ > +#define ETIMEDOUT_I2C 110 /* connection timed out */ > +#define EACK_I2C 6 /* remote I/O error */ You could use defines from include/linux/errno.h ? [snip] Reviewed-by: Heiko Schocher Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de