Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8532EC2D0A3 for ; Fri, 6 Nov 2020 14:36:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCB2920724 for ; Fri, 6 Nov 2020 14:36:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="KT3UtpoJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCB2920724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.20854.46887 (Exim 4.92) (envelope-from ) id 1kb2r1-0004o4-ST; Fri, 06 Nov 2020 14:36:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 20854.46887; Fri, 06 Nov 2020 14:36:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kb2r1-0004nx-Pb; Fri, 06 Nov 2020 14:36:39 +0000 Received: by outflank-mailman (input) for mailman id 20854; Fri, 06 Nov 2020 14:36:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kb2r0-0004nq-QB for xen-devel@lists.xenproject.org; Fri, 06 Nov 2020 14:36:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 79accbf8-bcab-4269-803c-97899b621e4a; Fri, 06 Nov 2020 14:36:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D72B0ADCD; Fri, 6 Nov 2020 14:36:36 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kb2r0-0004nq-QB for xen-devel@lists.xenproject.org; Fri, 06 Nov 2020 14:36:38 +0000 X-Inumbo-ID: 79accbf8-bcab-4269-803c-97899b621e4a Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 79accbf8-bcab-4269-803c-97899b621e4a; Fri, 06 Nov 2020 14:36:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604673396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAiBqHAiaj016BdKVwhEkwV1Lz5pLtNkIc2medpWSvE=; b=KT3UtpoJiS8/ub7OQrnhaXkFEBkKZNIDp5nc7I7nMFiYUJeOboKfrOGCTcuGqq2b61MZqk P8+90DX/OGD0UaX3fAd6Zpn8H9ZPMT8lqo+uvGH+/4/WOs/CzU207eOVfISmhdefS3oTgH 4rSGuUH/IuqUdJ79sQajobCsZTGQQak= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D72B0ADCD; Fri, 6 Nov 2020 14:36:36 +0000 (UTC) Subject: Re: [PATCH] tools/libs/light: correct bitmap operations To: Jan Beulich Cc: Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20201106140504.25488-1-jgross@suse.com> <61860ac6-133a-0393-e63c-8de9ea13e5f9@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <22a4dc50-4feb-a934-a58b-7ebcdcf9e3ab@suse.com> Date: Fri, 6 Nov 2020 15:36:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <61860ac6-133a-0393-e63c-8de9ea13e5f9@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 06.11.20 15:35, Jan Beulich wrote: > On 06.11.2020 15:05, Juergen Gross wrote: >> Libxl bitmap operations for single bits (test, set, reset) take the bit >> number as a signed integer without testing the value to be larger than >> 0. >> >> Correct that by adding the appropriate tests. >> >> Signed-off-by: Juergen Gross > > Wouldn't it be better to convert the parameter types to unsigned int? Those are official library interfaces. Can we just change them? Juergen