From: Laurent Dufour Date: Wed, 20 May 2020 17:35:24 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: relax check on H_SVM_INIT_ABORT Message-Id: <22bc6a9f-e7fd-eb24-3441-444216a38e60@linux.ibm.com> List-Id: References: <20200520165110.71020-1-ldufour@linux.ibm.com> <20200520193259.0b66db32@bahia.lan> In-Reply-To: <20200520193259.0b66db32@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Greg Kurz Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, paulus@samba.org, mpe@ellerman.id.au, sukadev@linux.ibm.com, linuxram@us.ibm.com Le 20/05/2020 à 19:32, Greg Kurz a écrit : > On Wed, 20 May 2020 18:51:10 +0200 > Laurent Dufour wrote: > >> The commit 8c47b6ff29e3 ("KVM: PPC: Book3S HV: Check caller of H_SVM_* >> Hcalls") added checks of secure bit of SRR1 to filter out the Hcall >> reserved to the Ultravisor. >> >> However, the Hcall H_SVM_INIT_ABORT is made by the Ultravisor passing the >> context of the VM calling UV_ESM. This allows the Hypervisor to return to >> the guest without going through the Ultravisor. Thus the Secure bit of SRR1 >> is not set in that particular case. >> >> In the case a regular VM is calling H_SVM_INIT_ABORT, this hcall will be >> filtered out in kvmppc_h_svm_init_abort() because kvm->arch.secure_guest is >> not set in that case. >> > > Why not checking vcpu->kvm->arch.secure_guest then ? I don't think that's the right place. > >> Fixes: 8c47b6ff29e3 ("KVM: PPC: Book3S HV: Check caller of H_SVM_* Hcalls") >> Signed-off-by: Laurent Dufour >> --- >> arch/powerpc/kvm/book3s_hv.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c >> index 93493f0cbfe8..eb1f96cb7b72 100644 >> --- a/arch/powerpc/kvm/book3s_hv.c >> +++ b/arch/powerpc/kvm/book3s_hv.c >> @@ -1099,9 +1099,7 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu) >> ret = kvmppc_h_svm_init_done(vcpu->kvm); >> break; >> case H_SVM_INIT_ABORT: >> - ret = H_UNSUPPORTED; >> - if (kvmppc_get_srr1(vcpu) & MSR_S) >> - ret = kvmppc_h_svm_init_abort(vcpu->kvm); > > or at least put a comment to explain why H_SVM_INIT_ABORT > doesn't have the same sanity check as the other SVM hcalls. I agree that might help. I'll send a v2 with a comment there. > >> + ret = kvmppc_h_svm_init_abort(vcpu->kvm); >> break; >> >> default: >