From: "plaisthos (Code Review)" Date: Wed, 15 Apr 2026 18:16:05 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., davidben@...410..., openvpn-devel@lists.sourceforge.net, frank@...2641..., max@...2606... Message-ID: <22df74b257cac363ef7e83d9406be4c474422b94-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="XyReW5cepa8="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Fix some CRL mixups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , davidben Cc: MaxF , openvpn-devel --XyReW5cepa8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, davidben, flichtenheld. plaisthos has posted comments on this change by davidben. ( http://gerrit.o= penvpn.net/c/openvpn/+/1289?usp=3Demail ) Change subject: ssl_openssl: Fix some CRL mixups ...................................................................... Patch Set 12: Code-Review+2 (1 comment) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1289/comment/6820491f_1542525e?usp=3D= email : PS12, Line 321: X509_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->cr= ls); > Does this function copy the CRLs into ctx, or a pointer to them? If it's = the latter, does this modif [=E2=80=A6] set0/get0 in OpenSSL terms mean no copy being made. We are really passing t= he pointer. This is not super avoid but session->opt->ssl_ctx is a pointer that poi= nts to the global tls_root_ctx. Commit 44dd39b3ef actually makes it a real = pointer. Before it was as well but in a very weird way that all the pointer= s in that ssl_ctx would point to a global object but ssl_ctx still being lo= cal. The pointer is technically dangling but since we set that before every acce= ss of it (in the callback), the pointer is also always updated. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1289?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31ac2a763209114267c35c4a9182a12d8d82f6fe Gerrit-Change-Number: 1289 Gerrit-PatchSet: 12 Gerrit-Owner: davidben Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: davidben Gerrit-Attention: MaxF Gerrit-Comment-Date: Wed, 15 Apr 2026 18:16:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: MaxF --XyReW5cepa8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, davidben, flichtenheld.

Patch set 12:Code-Review +2

= View Change

1 comment:

  • File src/openvpn/ssl_openssl.c= :

    • Patc= h Set #12, Line 321: = X509_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->crls);

      Does this function copy the CRLs into ctx, or a pointer t= o them? If it's the latter, does this modif [=E2=80=A6]

      This is not super avoid but session->opt->ssl_= ctx is a pointer that points to the global tls_root_ctx. Commit 44dd39b3ef = actually makes it a real pointer. Before it was as well but in a very weird= way that all the pointers in that ssl_ctx would point to a global object b= ut ssl_ctx still being local.

      The pointer is technically dangling but s= ince we set that before every access of it (in the callback), the pointer i= s also always updated.

To view, visit change 1289. To= unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I31ac2a763209114267c35c4a918= 2a12d8d82f6fe
Gerrit-Change-Number: 1289
Gerrit-PatchSet: 12
Gerrit-Owner: davidben <davidben@...410...&= gt;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: MaxF <max@...2606...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: davidben <davidben@...2975...= ...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Wed, 15 Apr 2026 18:16:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: MaxF <max@...2606...&g= t;
= --XyReW5cepa8=--