Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B028175A74 for ; Wed, 19 Aug 2026 11:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787138947; cv=none; b=e/OBWvndO4Pkf6yXIK9zBZkwnuDVU8vw4b2cFJ1kRCPwXcAkTdd24m/lw+1266SuYl+CL80PN8P/dVPqQWz/ozGTg/ENzHI5skl+mfLwWMpOQkem0XXRkIbINhJLMgRyqnF4CZ1n0LHnxNG++29FBO034jsLlwNfadZeqjxOuNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787138947; c=relaxed/simple; bh=4+98w1XYwLAEVWZchr3OiJkX1RmIsratTg1eeXkABJM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YZ9PMGfT8nb1599N5E49ZUgyMe2dX+180Gzdm/yVxTnvSUFIDAY5my5ZF/UPa4YFeiCy6HTJTuAaLHx5YCpVTNqQ+WeaObM3lLY2j0dNvOjOhlukHcTGNLFkreWQXTaRdUALL62d86369C+xigpP8c+8+MlQ/fewE3F0hH/ol0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=puGmMZnm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KJfWjMzn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="puGmMZnm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KJfWjMzn" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JA7oGh306489 for ; Wed, 19 Aug 2026 11:28:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C6fn7nuOdKxU5RfwSXqG52Pz3UneVX57/0Oi5HAx+7Y=; b=puGmMZnm+BPk4Xns p/71esqqiXhixGLhDTZhcaOasJS1igw3GqjX16FHEKINJUw2Y31otXYJRO17Xups Qs+3yUOsd/zkeLgg+Lc2ukQdba6kqKUcZqfk3R4pNC8WvFXdAfsY5X51bE9QEcje kUAXM6ukq1HsvWeeGOHy6jAJb0T3cRMb56tdFeW3m5V2ltRigEm+e+PpJ2UrFjxP r4eysisTw4Myac1v4LVPgEZWoFfHVGNGDUCReuHxIyrzIURFBT++UUwWdrwZATfJ UVWTYiTTx0GhaOTmhTEJE9tFLJ7hB2QLKP5Kllyx79dJ3v7WzJ2mFG/4MGYtwtoA ZOD35A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfmax0y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 11:28:59 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bfd1772d8so1584981cf.1 for ; Wed, 19 Aug 2026 04:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787138939; x=1787743739; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C6fn7nuOdKxU5RfwSXqG52Pz3UneVX57/0Oi5HAx+7Y=; b=KJfWjMznOnNpEFLBUI4EmC+AQhzzW8YYP12P2vwZEMRAC5iHTv0J+d7OTH65pRNC12 SxtTOPqK60dPz3O8zn4fJ9tXk3G3qpN6F0ErJTcBJJqJ6sC9SzE5qQdSBuqBxKX7Neaw 5fw0fanE6oWnQkiMFCiXzq2GXtgNmQs6R/dtI7njO53Is3jurLm1ojwcmE8IhdswmIJ4 HHPcKc6SragCcWS41TAUnYbxvNVtMl4saPOvaUBBYDt1Y1veS+SQOdxScK7OgQD09C4E 1wQLxJSxZ7hzbaBIiiK5oXXSWo7QDEV6RWe/EuSoiltTgO8C578JbqMGkeEXXzfYp5Rj 0vFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787138939; x=1787743739; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C6fn7nuOdKxU5RfwSXqG52Pz3UneVX57/0Oi5HAx+7Y=; b=BOdMwlqFRAoplLFF5zVwTuXLViRkEC2gkpXZ0Pv4S4ztly8/n/N6cKx6fCLlnArQQN Bl+ClfQx4ZVfszjJInwt2cJuhJTimnaZeJg2QoBgeeYWS1HntPCj/CQlRtpf0125uRYD OVfHYpDgRFD9X3sQK2pS+E2xDMSnRFb+fa+Uyl06x/lFq1FXSiHwDGGAwWZ9J4wEVTyT /u0hGyLeYpcfvVz+AGRUvgq7qWClqhFbr16a71s8wocH0s8fr5LvlqhPZiDcaWIO2GJK RdlrH/T3rfAXGIGIS03JWnJKuUr45T/bdhHywXtukOUGREGFTbYKFf62I51K6NXjEvFp dmIg== X-Forwarded-Encrypted: i=1; AHgh+Rp2OOwyrqxb2dHeaqy1cU7ObjNC1cCmB73/WHmHekVKQ/ysvdHV4qbgOEE/cLKTNgtwTewM/wwHurDIhg==@vger.kernel.org X-Gm-Message-State: AOJu0YwGBNNXjYZ8sa0byUTAzh/PJzD0yrgP2AYg6O6YrFC4dZ6qdvgA SRE+f80++SbSetzgorblyS8qJHbQJdQp/mn6APk4gyYn0VyqMQ6dW8y3ENy0kIA5cDHhoRROuxK aC/UieNySQeBgkJNb11Wff6JGprbdYzxNNc5yluwuo5Gd/w8sOwAFSsgmrjra0YeruA== X-Gm-Gg: AR+sD13wjr5L9VLtjyLy65+8unPmEC4WTEATUC0keBPFXbq6mLMh1PHJqeu7ErDelFC JpxKgFVLmqepDl0Puoc2TEI+0H9WpzeybHgRwqoqNXdkC9xA9AQtWriMVW6pRes4RHA9Hp0Gkjm KZ97PZHLCRq6ozFFWBC6p1/oni+KufBtFQfXxX9QW1/3ITjMPX+J//ql2/cQXyItrIXORjFM97e fZ3LtiPGILf5psSEsit0scrsZTMLXyMlhOtxiSH1GKmQjcLJQC84LqJMk1f7CfLcba/Eh3kOkXe 7DLzRtjkd3mgvi1RZ90F2ZB5iSrh1jp16+XdJ5Xoa2oH0qZURUyaWEHvFfFPWtYfiKdXqyYZFvE JENqRHgYJm3buTbIU+ey0Jvs5 X-Received: by 2002:ac8:7f0f:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-52dd5c958aamr25687931cf.3.1787138938949; Wed, 19 Aug 2026 04:28:58 -0700 (PDT) X-Received: by 2002:ac8:7f0f:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-52dd5c958aamr25687741cf.3.1787138938569; Wed, 19 Aug 2026 04:28:58 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c243c38af97sm59996166b.49.2026.08.19.04.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 04:28:57 -0700 (PDT) Message-ID: <22f01d3e-85ad-43ec-aa01-e5f3eced8703@oss.qualcomm.com> Date: Wed, 19 Aug 2026 13:28:55 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] media: qcom: iris: move OPP handling to VPU power transaction To: Hungyu Lin , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260729011001.16999-1-dennylin0707@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260729011001.16999-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: iVpBrrfXCJg-pjF0ooeqGL31DlzbDpD- X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDA4OCBTYWx0ZWRfXyvhNXSLTId/p 5bIkg0XspO8v84DiAyZUsyOe7stEXCOxUWAzbNj9fOxpmtnQHXRA7qDVVmvnAgNd/ZZu7sovaIw 0Nhr+s2Kb/luW5OhDF6yvDJ5RPZ4KQs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDA4OCBTYWx0ZWRfX79OyjFyg0j5c Sf/phd9EYOMreWgGFmYgNUFLR/Fb7aZg5hNNMshZrIj/pPmfzX0s6pPD92+4m9Ylyx/e4y8lh4H Ix8IL4DW1m0GBUddXi0ZHG95SNo2FW4NfdY4WQw+5Ht3HKEOdiMdEGHgpoD2PjfvYnVDIzp0mU5 dAXbRVkKY1e53zgOEo2HwIqIbOla0Xq+q6ck2r53k10HDgUxZkhQWpBsd1MwSgI3OJHRiq3aC2r Kj6SnJDOFK4g0VyW88oF8W21ObfEfqXCAuh4zzuDij2ZuCwNvA9WrhwrBZrye1Sf5+nrP1HAAB6 gQfq2Gn/hxZbGmDEXmMxdhD5xBdvMkmqJRFPqhqsu3Accqvv+OesnPsojMdJmW7skK+vwiDCbyt l1EbtYa6h1o+WY/OwTVpA2ij8XLq35agtQaEDN/Irm0f7PhQP8iHhq1ExSUqef66wC4ZUMTJ24W qe3Jg7xpqQMhxdx1EVg== X-Authority-Analysis: v=2.4 cv=aNrAb79m c=1 sm=1 tr=0 ts=6a85937b cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=pGLkceISAAAA:8 a=EgvVS7bLYM35CM27wtQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: iVpBrrfXCJg-pjF0ooeqGL31DlzbDpD- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190088 On 7/29/26 3:10 AM, Hungyu Lin wrote: > The power-domain helpers currently update the OPP for core->dev while > enabling or disabling one functional power domain. This makes a > transaction-wide performance state depend on a low-level helper and can > leave the maximum OPP selected when a later power-domain resume fails. > > Move the maximum OPP request to iris_vpu_power_on(), after the ICC vote > and before powering on the controller and hardware. Unwind the OPP vote > together with the ICC vote on failures. > > Keep the power-domain helpers limited to runtime PM and use > pm_runtime_resume_and_get() so a failed resume does not leave the usage > counter incremented. > > Fixes: bb8a95aa038e ("media: iris: implement power management") > Signed-off-by: Hungyu Lin > --- > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c > @@ -472,10 +472,14 @@ int iris_vpu_power_on(struct iris_core *core) > if (ret) > goto err; > > - ret = core->iris_platform_data->vpu_ops->power_on_controller(core); > + ret = iris_opp_set_rate(core->dev, ULONG_MAX); > if (ret) > goto err_unvote_icc; > > + ret = core->iris_platform_data->vpu_ops->power_on_controller(core); > + if (ret) > + goto err_opp; > + > ret = core->iris_platform_data->vpu_ops->power_on_hw(core); > if (ret) > goto err_power_off_ctrl; > @@ -495,6 +499,8 @@ int iris_vpu_power_on(struct iris_core *core) > > err_power_off_ctrl: > core->iris_platform_data->vpu_ops->power_off_controller(core); > +err_opp: > + iris_opp_set_rate(core->dev, 0); iris_opp_set_rate(0) will almost never do what you want - it will set the rate to something lower, but not disable the clocks or drop the power vote. Dropping the vote will happen as the device (runtime) suspends. This is an existing "issue" in the driver Konrad