From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types Date: Sat, 09 May 2020 11:15:31 +0200 Message-ID: <2337210.yqbmfTWyIV@kreacher> References: <20200505111810.65586-1-malattia@linux.it> <20200505111810.65586-2-malattia@linux.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: Andy Shevchenko Cc: Mattia Dongili , "Schmauss, Erik" , ACPI Devel Maling List , "Rafael J. Wysocki" , Darren Hart , Andy Shevchenko , Platform Driver , Dominik Mierzejewski , William Bader List-Id: platform-driver-x86.vger.kernel.org On Tuesday, May 5, 2020 2:27:15 PM CEST Andy Shevchenko wrote: > +Cc ACPI(CA) people > > On Tue, May 5, 2020 at 1:16 PM wrote: > > After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer > > objects for ASL create_field() operator") ACPICA creates buffers even > > when new fields are small enough to fit into an integer. > > > Many SNC calls counted on the old behaviour. > > Rafael, Erik, is it correct behaviour from ACPICA p.o.v. nowadays or > should be fixed rather there? The new behavior is correct and it is needed to avoid other failures elsewhere. Unfortunately, all of the call sites assuming that the conversion will happen need to be fixed. Cheers!