Content-Type: multipart/mixed; boundary="===============3779081948679922631==" MIME-Version: 1.0 From: Heiko Stübner To: kbuild-all@lists.01.org Subject: Re: [PATCH 1/6] pinctrl: rockchip: make driver be tristate module Date: Sat, 05 Sep 2020 23:51:36 +0200 Message-ID: <2350331.06pZ62Lms5@diego> In-Reply-To: <202009011812.LO6Db3sN%lkp@intel.com> List-Id: --===============3779081948679922631== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, Am Dienstag, 1. September 2020, 12:13:16 CEST schrieb kernel test robot: > Hi Jianqun, > = > Thank you for the patch! Yet something to improve: > = > [auto build test ERROR on rockchip/for-next] > [also build test ERROR on pinctrl/devel v5.9-rc3 next-20200828] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Jianqun-Xu/rockchip-pinc= trl-fixes-for-GKI/20200831-165040 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockc= hip.git for-next > config: x86_64-randconfig-m031-20200901 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > reproduce (this is a W=3D1 build): > # save the attached .config to linux build tree > make W=3D1 ARCH=3Dx86_64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > drivers/pinctrl/pinctrl-rockchip.c: In function 'rockchip_pinctrl_pars= e_groups': > >> drivers/pinctrl/pinctrl-rockchip.c:2881:9: error: implicit declaration= of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_gener= ic_dump_config'? [-Werror=3Dimplicit-function-declaration] > 2881 | ret =3D pinconf_generic_parse_dt_config(np_config, NULL, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | pinconf_generic_dump_config > drivers/pinctrl/pinctrl-rockchip.c: In function 'rockchip_gpiolib_regi= ster': > >> drivers/pinctrl/pinctrl-rockchip.c:3473:5: error: 'struct gpio_chip' h= as no member named 'of_node' > 3473 | gc->of_node =3D bank->of_node; > | ^~ > At top level: > drivers/pinctrl/pinctrl-rockchip.c:2804:34: warning: 'rockchip_bank_ma= tch' defined but not used [-Wunused-const-variable=3D] > 2804 | static const struct of_device_id rockchip_bank_match[] =3D { > | ^~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors these errors are unrelated to this patch, and I addressed them in [PATCH] pinctrl: rockchip: depend on OF [0] Heiko [0] http://lore.kernel.org/r/20200905214955.907950-1-heiko(a)sntech.de > = > # https://github.com/0day-ci/linux/commit/38fa905767d010bbbc1035b48494d4a= 83bb72410 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Jianqun-Xu/rockchip-pinctrl-fixes-for-GK= I/20200831-165040 > git checkout 38fa905767d010bbbc1035b48494d4a83bb72410 > vim +2881 drivers/pinctrl/pinctrl-rockchip.c > = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2823 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2824 static int rockchip= _pinctrl_parse_groups(struct device_node *np, > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2825 struct r= ockchip_pin_group *grp, > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2826 struct r= ockchip_pinctrl *info, > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2827 u32 inde= x) > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2828 { > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2829 struct rockchip_pi= n_bank *bank; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2830 int size; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2831 const __be32 *list; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2832 int num; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2833 int i, j; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2834 int ret; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2835 = > 94f4e54cecaf3e Rob Herring 2018-08-27 2836 dev_dbg(info->dev, "gro= up(%d): %pOFn\n", index, np); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2837 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2838 /* Initialise grou= p */ > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2839 grp->name =3D np->= name; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2840 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2841 /* > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2842 * the binding for= mat is rockchip,pins =3D , > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2843 * do sanity check= and calculate pins number > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2844 */ > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2845 list =3D of_get_pr= operty(np, "rockchip,pins", &size); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2846 /* we do not check= return since it's safe node passed down */ > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2847 size /=3D sizeof(*= list); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2848 if (!size || size = % 4) { > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2849 dev_err(info->dev= , "wrong pins number or pins and configs should be by 4\n"); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2850 return -EINVAL; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2851 } > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2852 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2853 grp->npins =3D siz= e / 4; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2854 = > a86854d0c599b3 Kees Cook 2018-06-12 2855 grp->pins =3D devm_kcal= loc(info->dev, grp->npins, sizeof(unsigned int), > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2856 GFP_KERNEL); > a86854d0c599b3 Kees Cook 2018-06-12 2857 grp->data =3D devm_kcal= loc(info->dev, > a86854d0c599b3 Kees Cook 2018-06-12 2858 grp->npins, > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2859 sizeof(struct = rockchip_pin_config), > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2860 GFP_KERNEL); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2861 if (!grp->pins || = !grp->data) > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2862 return -ENOMEM; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2863 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2864 for (i =3D 0, j = =3D 0; i < size; i +=3D 4, j++) { > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2865 const __be32 *pha= ndle; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2866 struct device_nod= e *np_config; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2867 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2868 num =3D be32_to_c= pu(*list++); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2869 bank =3D bank_num= _to_bank(info, num); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2870 if (IS_ERR(bank)) > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2871 return PTR_ERR(b= ank); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2872 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2873 grp->pins[j] =3D = bank->pin_base + be32_to_cpu(*list++); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2874 grp->data[j].func= =3D be32_to_cpu(*list++); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2875 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2876 phandle =3D list+= +; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2877 if (!phandle) > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2878 return -EINVAL; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2879 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2880 np_config =3D of_= find_node_by_phandle(be32_to_cpup(phandle)); > dd4d01f7bad886 Soren Brinkmann 2015-01-09 @2881 ret =3D pinconf_generi= c_parse_dt_config(np_config, NULL, > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2882 &grp->data[j].c= onfigs, &grp->data[j].nconfigs); > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2883 if (ret) > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2884 return ret; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2885 } > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2886 = > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2887 return 0; > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2888 } > d3e5116119bd02 Heiko St=C3=BCbner 2013-06-10 2889 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > = --===============3779081948679922631==--