Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32BF6C3DA4A for ; Fri, 9 Aug 2024 06:28:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1scJ6Z-00087Z-47; Fri, 09 Aug 2024 02:28:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scJ6W-0007yN-J2 for qemu-devel@nongnu.org; Fri, 09 Aug 2024 02:28:00 -0400 Received: from torg.zytor.com ([2607:7c80:54:3::138] helo=mail.zytor.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scJ6U-0005fs-Lt for qemu-devel@nongnu.org; Fri, 09 Aug 2024 02:28:00 -0400 Received: from [192.168.7.205] ([71.202.166.45]) (authenticated bits=0) by mail.zytor.com (8.17.2/8.17.1) with ESMTPSA id 4796Rk6I1585377 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Thu, 8 Aug 2024 23:27:47 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 4796Rk6I1585377 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2024071601; t=1723184867; bh=Et0EdNR2qJ+p2LDz5KX4X3KS5pgTIX1n3PtZB89fMhA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hJamcCrQd8vN+Fuw2My09bSDqAh33mheq8mEwmjOVbA/KD36PeQLwEjP9QrXtxpVk KpR4gYqVHgSFlRYFyKzVTmHhe5hZvT3yHXMRWWhbN0CQ3ipWS8IvFmrQOVqKO+87if 3krka+ew3dsf3iOCI4obQ8wjUkKnJWi1pJgHVAb3y/IDSdTLULFsA/ysuGIzATXTrB nLGjTu0wZLEGb/dQAeqIPo1nA4kKbJF51Z96y0BSdurAJ2FDrC/Y19lVX1dGlKmwns SX3f84jjvVkwJeDLBsjL1KL5WYGfHHwRPIplDK+7aahinDTenlJKeoITNGHelp0vBI yO2q40Ey+6uEA== Message-ID: <235c9a61-fe2c-4124-acbb-e7ab287164fc@zytor.com> Date: Thu, 8 Aug 2024 23:27:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] target/i386: Raise the highest index value used for any VMCS encoding To: Zhao Liu Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com, lei4.wang@intel.com, xin3.li@intel.com References: <20240807081813.735158-1-xin@zytor.com> <20240807081813.735158-4-xin@zytor.com> Content-Language: en-US From: Xin Li Autocrypt: addr=xin@zytor.com; keydata= xsDNBGUPz1cBDACS/9yOJGojBFPxFt0OfTWuMl0uSgpwk37uRrFPTTLw4BaxhlFL0bjs6q+0 2OfG34R+a0ZCuj5c9vggUMoOLdDyA7yPVAJU0OX6lqpg6z/kyQg3t4jvajG6aCgwSDx5Kzg5 Rj3AXl8k2wb0jdqRB4RvaOPFiHNGgXCs5Pkux/qr0laeFIpzMKMootGa4kfURgPhRzUaM1vy bsMsL8vpJtGUmitrSqe5dVNBH00whLtPFM7IbzKURPUOkRRiusFAsw0a1ztCgoFczq6VfAVu raTye0L/VXwZd+aGi401V2tLsAHxxckRi9p3mc0jExPc60joK+aZPy6amwSCy5kAJ/AboYtY VmKIGKx1yx8POy6m+1lZ8C0q9b8eJ8kWPAR78PgT37FQWKYS1uAroG2wLdK7FiIEpPhCD+zH wlslo2ETbdKjrLIPNehQCOWrT32k8vFNEMLP5G/mmjfNj5sEf3IOKgMTMVl9AFjsINLHcxEQ 6T8nGbX/n3msP6A36FDfdSEAEQEAAc0WWGluIExpIDx4aW5Aenl0b3IuY29tPsLBDQQTAQgA NxYhBIUq/WFSDTiOvUIqv2u9DlcdrjdRBQJlD89XBQkFo5qAAhsDBAsJCAcFFQgJCgsFFgID AQAACgkQa70OVx2uN1HUpgv/cM2fsFCQodLArMTX5nt9yqAWgA5t1srri6EgS8W3F+3Kitge tYTBKu6j5BXuXaX3vyfCm+zajDJN77JHuYnpcKKr13VcZi1Swv6Jx1u0II8DOmoDYLb1Q2ZW v83W55fOWJ2g72x/UjVJBQ0sVjAngazU3ckc0TeNQlkcpSVGa/qBIHLfZraWtdrNAQT4A1fa sWGuJrChBFhtKbYXbUCu9AoYmmbQnsx2EWoJy3h7OjtfFapJbPZql+no5AJ3Mk9eE5oWyLH+ QWqtOeJM7kKvn/dBudokFSNhDUw06e7EoVPSJyUIMbYtUO7g2+Atu44G/EPP0yV0J4lRO6EA wYRXff7+I1jIWEHpj5EFVYO6SmBg7zF2illHEW31JAPtdDLDHYcZDfS41caEKOQIPsdzQkaQ oW2hchcjcMPAfyhhRzUpVHLPxLCetP8vrVhTvnaZUo0xaVYb3+wjP+D5j/3+hwblu2agPsaE vgVbZ8Fx3TUxUPCAdr/p73DGg57oHjgezsDNBGUPz1gBDAD4Mg7hMFRQqlzotcNSxatlAQNL MadLfUTFz8wUUa21LPLrHBkUwm8RujehJrzcVbPYwPXIO0uyL/F///CogMNx7Iwo6by43KOy g89wVFhyy237EY76j1lVfLzcMYmjBoTH95fJC/lVb5Whxil6KjSN/R/y3jfG1dPXfwAuZ/4N cMoOslWkfZKJeEut5aZTRepKKF54T5r49H9F7OFLyxrC/uI9UDttWqMxcWyCkHh0v1Di8176 jjYRNTrGEfYfGxSp+3jYL3PoNceIMkqM9haXjjGl0W1B4BidK1LVYBNov0rTEzyr0a1riUrp Qk+6z/LHxCM9lFFXnqH7KWeToTOPQebD2B/Ah5CZlft41i8L6LOF/LCuDBuYlu/fI2nuCc8d m4wwtkou1Y/kIwbEsE/6RQwRXUZhzO6llfoN96Fczr/RwvPIK5SVMixqWq4QGFAyK0m/1ap4 bhIRrdCLVQcgU4glo17vqfEaRcTW5SgX+pGs4KIPPBE5J/ABD6pBnUUAEQEAAcLA/AQYAQgA JhYhBIUq/WFSDTiOvUIqv2u9DlcdrjdRBQJlD89ZBQkFo5qAAhsMAAoJEGu9DlcdrjdR4C0L /RcjolEjoZW8VsyxWtXazQPnaRvzZ4vhmGOsCPr2BPtMlSwDzTlri8BBG1/3t/DNK4JLuwEj OAIE3fkkm+UG4Kjud6aNeraDI52DRVCSx6xff3bjmJsJJMb12mWglN6LjdF6K+PE+OTJUh2F dOhslN5C2kgl0dvUuevwMgQF3IljLmi/6APKYJHjkJpu1E6luZec/lRbetHuNFtbh3xgFIJx 2RpgVDP4xB3f8r0I+y6ua+p7fgOjDLyoFjubRGed0Be45JJQEn7A3CSb6Xu7NYobnxfkwAGZ Q81a2XtvNS7Aj6NWVoOQB5KbM4yosO5+Me1V1SkX2jlnn26JPEvbV3KRFcwV5RnDxm4OQTSk PYbAkjBbm+tuJ/Sm+5Yp5T/BnKz21FoCS8uvTiziHj2H7Cuekn6F8EYhegONm+RVg3vikOpn gao85i4HwQTK9/D1wgJIQkdwWXVMZ6q/OALaBp82vQ2U9sjTyFXgDjglgh00VRAHP7u1Rcu4 l75w1xInsg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:7c80:54:3::138; envelope-from=xin@zytor.com; helo=mail.zytor.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org >> + if (f[FEAT_7_1_EAX] & CPUID_7_1_EAX_FRED) { >> + /* FRED injected-event data (0x2052). */ >> + kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x52); > > HMM, I have the questions when I check the FRED spec. > > Section 9.3.4 said, (for injected-event data) "This field has uses the > encoding pair 2052H/2053H." > > So why adjust the highest index to 0x52 other than 0x53? For 16-bit, 32-bit, and natural-width fields, they must be read/write as a whole, thus the lowest bit of their encoding must be 0. A 64-bit VMCS field can be accessed as two 32-bit fields, with the higher order half using an odd VMCS encoding. But conceptually they should be treated as a whole 64-bit field. Better to refer to Intel SDM 25.11.2 VMREAD, VMWRITE, and Encodings of VMCS Fields. > > And it seems FRED introduces another field "original-event data" > (0x2404/0x2405), why not consider this field here as well? > >> + } else if (f[FEAT_VMX_EXIT_CTLS] & >> + VMX_VM_EXIT_ACTIVATE_SECONDARY_CONTROLS) { >> + /* Secondary VM-exit controls (0x2044). */ >> + kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x44); >> + } else if (f[FEAT_VMX_SECONDARY_CTLS] & VMX_SECONDARY_EXEC_TSC_SCALING) { >> /* TSC multiplier (0x2032). */ >> kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x32); >> } else { > > Maybe we could adjust the index in a cleaner way like > x86_cpu_adjust_level(), but the current case-by-case is ok for me as > well. Yeah, that sounds a good idea. But the code hasn't gone wild...