Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 893E6C54E94 for ; Thu, 26 Jan 2023 09:25:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CEA784E8B; Thu, 26 Jan 2023 10:25:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674725146; bh=9cACG8NiSPDF1kH9CgtrZFzSXNb7CEKjuwtRQb8XdjE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UQD2diCPvJxCXkMYQkCDdlWyPaRs/HZQlRISvC7XL/19WQFRv1jnwouGOC6SxUP8l IaHMifpns5aiMw1Zfq6VlXrKz8Tlkubs1Dq2IHrffq7b7ujuJ3GAtvLDTQ+ugVRGqt rGSEpKwU69XKDyUZV1Mx7TcRDDp9I44z5L7aWruMvsJ7W6a8cioN7AF+dJKWOdgmnZ Tq3lJ2JExYYZePYOfhNJctKJSdox45QVU8oAdNiglbMyaRyOCP2HqFeMetfkd2zJbY GUuscRoZ0sKQZu8JepFsiaC4ciUyL9DFPIJjTg7oj9BKLU3LQkC3/kYQPEJ71Z3XLQ FGHqdkV3mhXhQ== Received: by phobos.denx.de (Postfix, from userid 109) id AA25D854DF; Thu, 26 Jan 2023 10:25:45 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [80.241.59.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E686B84954 for ; Thu, 26 Jan 2023 10:25:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4P2b0g5MJ8z9sNm; Thu, 26 Jan 2023 10:25:39 +0100 (CET) Message-ID: <23cec7eb-431d-1e4f-5508-eaff1764d236@denx.de> Date: Thu, 26 Jan 2023 10:25:38 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] arm: kirkwood: Use Kirkwood common early malloc area for various Kirkwood boards Content-Language: en-US To: Tony Dinh , U-Boot Mailing List Cc: Michael Walle , =?UTF-8?B?UGFsaSBSb2jvv71y?= , Tom Rini , Dave Purdy , Luka Perkov References: <20230123083935.11077-1-mibodhi@gmail.com> From: Stefan Roese In-Reply-To: <20230123083935.11077-1-mibodhi@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/23/23 09:39, Tony Dinh wrote: > For Kirkwood boards, it is necessary to have early malloc in DRAM area > when Driver Model for Serial is enabled. This patch removes individual > board settings for early malloc in various Kirkwood boards, and uses the > Kirkwood commonly defined settings in arch/arm/mach-kirkwood/Kconfig. > > Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan > --- > > configs/dockstar_defconfig | 3 --- > configs/dreamplug_defconfig | 3 --- > configs/goflexhome_defconfig | 3 --- > configs/iconnect_defconfig | 3 --- > configs/nsa310s_defconfig | 3 --- > configs/pogo_e02_defconfig | 3 --- > configs/pogo_v4_defconfig | 3 --- > configs/sheevaplug_defconfig | 3 --- > 8 files changed, 24 deletions(-) > > diff --git a/configs/dockstar_defconfig b/configs/dockstar_defconfig > index a17d01f3fd..d08182d270 100644 > --- a/configs/dockstar_defconfig > +++ b/configs/dockstar_defconfig > @@ -17,9 +17,6 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-dockstar" > CONFIG_SYS_PROMPT="DockStar> " > CONFIG_IDENT_STRING="\nSeagate FreeAgent DockStar" > CONFIG_SYS_LOAD_ADDR=0x800000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > -# CONFIG_SYS_MALLOC_F is not set > CONFIG_BOOTDELAY=3 > CONFIG_USE_BOOTCOMMAND=y > CONFIG_BOOTCOMMAND="setenv bootargs ${console} ${mtdparts} ${bootargs_root}; ubi part root; ubifsmount ubi:root; ubifsload 0x800000 ${kernel}; ubifsload 0x1100000 ${initrd}; bootm 0x800000 0x1100000" > diff --git a/configs/dreamplug_defconfig b/configs/dreamplug_defconfig > index 6deb05575c..3cff5034b9 100644 > --- a/configs/dreamplug_defconfig > +++ b/configs/dreamplug_defconfig > @@ -17,9 +17,6 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-dreamplug" > CONFIG_IDENT_STRING="\nMarvell-DreamPlug" > CONFIG_SYS_LOAD_ADDR=0x800000 > CONFIG_ENV_ADDR=0x100000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > -# CONFIG_SYS_MALLOC_F is not set > CONFIG_BOOTDELAY=3 > CONFIG_USE_BOOTCOMMAND=y > CONFIG_BOOTCOMMAND="setenv ethact ethernet-controller@72000; ${x_bootcmd_ethernet}; setenv ethact ethernet-controller@76000; ${x_bootcmd_ethernet}; ${x_bootcmd_usb}; ${x_bootcmd_kernel}; setenv bootargs ${x_bootargs} ${x_bootargs_root}; bootm 0x6400000;" > diff --git a/configs/goflexhome_defconfig b/configs/goflexhome_defconfig > index 8ee1183309..8dc285241b 100644 > --- a/configs/goflexhome_defconfig > +++ b/configs/goflexhome_defconfig > @@ -17,9 +17,6 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-goflexnet" > CONFIG_SYS_PROMPT="GoFlexHome> " > CONFIG_IDENT_STRING="\nSeagate GoFlex Home" > CONFIG_SYS_LOAD_ADDR=0x800000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > -# CONFIG_SYS_MALLOC_F is not set > CONFIG_BOOTDELAY=3 > CONFIG_USE_BOOTCOMMAND=y > CONFIG_BOOTCOMMAND="setenv bootargs ${console} ${mtdparts} ${bootargs_root}; ubi part root; ubifsmount ubi:root; ubifsload 0x800000 ${kernel}; bootm 0x800000" > diff --git a/configs/iconnect_defconfig b/configs/iconnect_defconfig > index f536dd3bcb..94f4ee2772 100644 > --- a/configs/iconnect_defconfig > +++ b/configs/iconnect_defconfig > @@ -17,9 +17,6 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-iconnect" > CONFIG_SYS_PROMPT="iConnect> " > CONFIG_IDENT_STRING=" Iomega iConnect" > CONFIG_SYS_LOAD_ADDR=0x800000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > -# CONFIG_SYS_MALLOC_F is not set > CONFIG_BOOTDELAY=3 > CONFIG_USE_BOOTCOMMAND=y > CONFIG_BOOTCOMMAND="setenv bootargs ${console} ${mtdparts} ${bootargs_root}; ubi part rootfs; ubifsmount ubi:rootfs; ubifsload 0x800000 ${kernel}; bootm 0x800000" > diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig > index e7d6ffd925..ab896ff54e 100644 > --- a/configs/nsa310s_defconfig > +++ b/configs/nsa310s_defconfig > @@ -9,7 +9,6 @@ CONFIG_CMDLINE_TAG=y > CONFIG_INITRD_TAG=y > CONFIG_SYS_KWD_CONFIG="board/zyxel/nsa310s/kwbimage.cfg" > CONFIG_TEXT_BASE=0x600000 > -CONFIG_SYS_MALLOC_F_LEN=0x400 > CONFIG_NR_DRAM_BANKS=2 > CONFIG_TARGET_NSA310S=y > CONFIG_ENV_SIZE=0x20000 > @@ -19,8 +18,6 @@ CONFIG_SYS_PROMPT="NSA310s> " > CONFIG_IDENT_STRING="\nZyXEL NSA310S/320S 1/2-Bay Power Media Server" > CONFIG_SYS_LOAD_ADDR=0x800000 > CONFIG_DISTRO_DEFAULTS=y > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > CONFIG_BOOTDELAY=3 > CONFIG_USE_PREBOOT=y > # CONFIG_DISPLAY_BOARDINFO is not set > diff --git a/configs/pogo_e02_defconfig b/configs/pogo_e02_defconfig > index 116e5d0ed3..067fb9e13b 100644 > --- a/configs/pogo_e02_defconfig > +++ b/configs/pogo_e02_defconfig > @@ -17,9 +17,6 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-pogo_e02" > CONFIG_SYS_PROMPT="PogoE02> " > CONFIG_IDENT_STRING="\nPogo E02" > CONFIG_SYS_LOAD_ADDR=0x800000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > -# CONFIG_SYS_MALLOC_F is not set > CONFIG_BOOTDELAY=3 > CONFIG_USE_BOOTCOMMAND=y > CONFIG_BOOTCOMMAND="setenv bootargs $(bootargs_console); run bootcmd_usb; bootm 0x00800000 0x01100000" > diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig > index 57ec6f1fb6..3860ad30d3 100644 > --- a/configs/pogo_v4_defconfig > +++ b/configs/pogo_v4_defconfig > @@ -9,7 +9,6 @@ CONFIG_CMDLINE_TAG=y > CONFIG_INITRD_TAG=y > CONFIG_SYS_KWD_CONFIG="board/cloudengines/pogo_v4/kwbimage.cfg" > CONFIG_TEXT_BASE=0x600000 > -CONFIG_SYS_MALLOC_F_LEN=0x400 > CONFIG_TARGET_POGO_V4=y > CONFIG_ENV_SIZE=0x20000 > CONFIG_ENV_OFFSET=0xC0000 > @@ -18,8 +17,6 @@ CONFIG_SYS_PROMPT="Pogo_V4> " > CONFIG_IDENT_STRING="\nPogoplug V4" > CONFIG_SYS_LOAD_ADDR=0x800000 > CONFIG_DISTRO_DEFAULTS=y > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > CONFIG_BOOTSTAGE=y > CONFIG_SHOW_BOOT_PROGRESS=y > CONFIG_BOOTDELAY=10 > diff --git a/configs/sheevaplug_defconfig b/configs/sheevaplug_defconfig > index 79f36c0360..cb38a3fbd5 100644 > --- a/configs/sheevaplug_defconfig > +++ b/configs/sheevaplug_defconfig > @@ -16,9 +16,6 @@ CONFIG_ENV_OFFSET=0x80000 > CONFIG_DEFAULT_DEVICE_TREE="kirkwood-sheevaplug" > CONFIG_IDENT_STRING="\nMarvell-Sheevaplug" > CONFIG_SYS_LOAD_ADDR=0x800000 > -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc8012000 > -# CONFIG_SYS_MALLOC_F is not set > CONFIG_HAS_BOARD_SIZE_LIMIT=y > CONFIG_BOARD_SIZE_LIMIT=524288 > CONFIG_BOOTDELAY=3 Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de