From: bugtrack@alsa-project.org Subject: [ALSA - driver 0001239]: forgotten __init and __exit in memory.c Date: Mon, 25 Jul 2005 14:54:41 +0200 Message-ID: <23d0128a84da05446f450d12b09f1093@bugtrack.alsa-project.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bugtrack.alsa-project.org (gate.perex.cz [82.113.61.162]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 5B51A18D for ; Mon, 25 Jul 2005 14:54:41 +0200 (MEST) Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org A NOTE has been added to this issue. ====================================================================== ====================================================================== Reported By: Henne Assigned To: ====================================================================== Project: ALSA - driver Issue ID: 1239 Category: 1_OTHERS Reproducibility: always Severity: minor Priority: normal Status: new Distribution: Kernel Version: ====================================================================== Date Submitted: 07-07-2005 10:37 CEST Last Modified: 07-25-2005 14:54 CEST ====================================================================== Summary: forgotten __init and __exit in memory.c Description: I think that snd_memory_init() should get an __init, and snd_memory_exit() an __exit, cause that __init function isn't called again and can be removed from the memory. That doesn't save too much space, but it's cleaner and mekes more sense . The patch I added will fix it and is made for the current cvs version(memory.c 1.38). ====================================================================== ---------------------------------------------------------------------- tiwai - 07-08-05 11:52 ---------------------------------------------------------------------- __exit can't be applied since it's called from init function, too. Could you regenerate the patch? ---------------------------------------------------------------------- Henne - 07-25-05 14:54 ---------------------------------------------------------------------- Here is the new one! Issue History Date Modified Username Field Change ====================================================================== 07-07-05 10:37 Henne New Issue 07-07-05 10:37 Henne File Added: memory_c.diff 07-08-05 11:52 tiwai Note Added: 0005410 07-12-05 11:41 Henne File Added: memory_c_1.diff 07-25-05 14:54 Henne Note Added: 0005563 ====================================================================== ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click