Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5996CC10F11 for ; Sat, 13 Apr 2019 23:44:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B1B1208E3 for ; Sat, 13 Apr 2019 23:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ebva1Mcr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727190AbfDMXoq (ORCPT ); Sat, 13 Apr 2019 19:44:46 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:42451 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727159AbfDMXoq (ORCPT ); Sat, 13 Apr 2019 19:44:46 -0400 Received: by mail-pl1-f193.google.com with SMTP id cv12so6822188plb.9 for ; Sat, 13 Apr 2019 16:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7K14sEDabTbhJ1SY1dn1ajIB9elKETOrQTAh/584Xa0=; b=Ebva1McrOLu3YkpascJebaykLgWI400r6mCYvd5gyqeA+RP2WlhpjwOcpdHUEvnVqn AGIXpFluSv0gx8zPSuwdg75MBFGul6LSMgW+CyChoTGIRwjITJedDuXWJmIpyzLfUf/V kzIEQ8fkpLeCRwPL3/vkW8uFZeiLOZ1pVXcwRJp95MyTd+gvLXkO3P2EzUO2DKRUD1TQ hVGO+35HEsKqwKNkztkVooRDR2nbovqTI16Ps+PWvuBq0Enymk0abniCDTMkvVQWlCYy CRBkL6roVqj2c0JQ/kOIKAR8HCihF30tnqPtsSuDY72XYngVXN7sA8UWJYhMwAgNxZqW kILA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7K14sEDabTbhJ1SY1dn1ajIB9elKETOrQTAh/584Xa0=; b=aKI/mVMJpxEMWmsYtKOhThd7KQD1dVFXu1XR/AE+YVPRCSHygJyLeOkwVyvLg+A0qG lYhIStaP07QcJggmJo2/rhoY8EORzEKbHXuVuEN+L+h0IuUy1Ytztv84PSkOJIyyJuuy xIkgNYFfLZkkQOvfOMHUHjNBKrSzNyA7ponpdShptvMlvlAAcOb1n4F3Vn4SCVFiRFn9 +8ooAMdZlwr9MIp7148gjJ6fefGfn712svCrU/aHiSCXkayyieihuZae+m0Z7DN9Beqc 2+bJtR33aEo0MY0I1uaeVBj/tGwnJFz8Szw6NZc9tWwJl0eIjkT1XdhgxnCGkHEYZo4f pl1Q== X-Gm-Message-State: APjAAAXBZMXR3OGnfO5eFRIaK5AiZiUZbfdLmBWEZsATyDlUHp/9sTUS JHbnyeYsYdIamUzLZuCyso77RoMu X-Google-Smtp-Source: APXvYqzRMXnlyBdPAUMgz8/JpU0ut1tIz3xnQ/P4C0wUxmTlyOtY7f7w5zXMprvfck0Dqx2jGJrRag== X-Received: by 2002:a17:902:7883:: with SMTP id q3mr66643481pll.60.1555199085386; Sat, 13 Apr 2019 16:44:45 -0700 (PDT) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id v19sm61566227pfn.62.2019.04.13.16.44.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Apr 2019 16:44:43 -0700 (PDT) Subject: Re: [PATCH net] ipv4: recompile ip options in ipv4_link_failure To: David Miller , ssuryaextr@gmail.com Cc: netdev@vger.kernel.org References: <20190412201927.7615-1-ssuryaextr@gmail.com> <20190412.172421.1257922527433996366.davem@davemloft.net> From: Eric Dumazet Message-ID: <2414eaeb-7b6f-f5cf-e4b4-744b11d5641e@gmail.com> Date: Sat, 13 Apr 2019 16:44:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190412.172421.1257922527433996366.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/12/2019 05:24 PM, David Miller wrote: > From: Stephen Suryaputra > Date: Fri, 12 Apr 2019 16:19:27 -0400 > >> Recompile IP options since IPCB may not be valid anymore when >> ipv4_link_failure is called from arp_error_report. >> >> Refer to the commit 3da1ed7ac398 ("net: avoid use IPCB in cipso_v4_error") >> and the commit before that (9ef6b42ad6fd) for a similar issue. >> >> Signed-off-by: Stephen Suryaputra > > Applied. > I believe __ip_options_compile() needs to be called from rcu_read_lock() I will send a fix.