Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27852C2D0F3 for ; Wed, 1 Apr 2020 16:46:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 529EB2071A for ; Wed, 1 Apr 2020 16:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="OybuNcGf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 529EB2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJgUa-0000gV-Mh; Wed, 01 Apr 2020 16:45:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJgUZ-0000gQ-Rf for xen-devel@lists.xenproject.org; Wed, 01 Apr 2020 16:45:27 +0000 X-Inumbo-ID: 2fedfd2e-7438-11ea-bb07-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2fedfd2e-7438-11ea-bb07-12813bfff9fa; Wed, 01 Apr 2020 16:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1585759526; h=from:mime-version:content-transfer-encoding:message-id: date:to:cc:subject:in-reply-to:references; bh=icxvwV4wEtwBIOaM20BsS4ts4bjFZhzkus5WaWxIA/c=; b=OybuNcGfVTRsxurYPi4VZHgfVwFWNpV2enRUXZTlNVRjFLpxtu/ApkZZ 0knbK9bTdmui8avyRsGhgBMbNVCI76goV12oWFd6I+pO3HrvxgA3bjW7o hI92rUmYukGNVhwH1PDuGW10IIiTSlaEjwJy5YFIN8gEUBCDAhQbwsvvV c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: eYHeqXxuJwGIchjVCjPGMrbGOc6JZs7UrUQbDHNm8ShyCrmgfnJJflpb+tn41zYEB3yw0n91cM 4uO1WMK1W+ZbK9byFRS51kzRqYErkd17MJLYx9in0WqqAP4dzvCKUqt8gISOzSEYCD7heLVYc6 5ekpm5Y7hXZIOnyn50SZLm1jHO/kjoFYVqwJ5rndrxLaRZ66DhzrURxJJ76pBRtJJErVqiRfVM 7xVdSueE/kSJq5PC7+KpAYwKoOKhTVqpZw262yr1N6fqHtLham2XgKAcYPLIYhYewH55h2E6ZW xZw= X-SBRS: 2.7 X-MesageID: 15422037 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,332,1580792400"; d="scan'208";a="15422037" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24196.50465.468849.680260@mariner.uk.xensource.com> Date: Wed, 1 Apr 2020 17:45:21 +0100 To: Roger Pau Monne Subject: Re: [PATCH] timeout: adjust timeout when running nested tests In-Reply-To: <20200401133740.64685-1-roger.pau@citrix.com> References: <20200401133740.64685-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Roger Pau Monne writes ("[PATCH] timeout: adjust timeout when running nested tests"): > sub target_adjust_timeout ($$) { > my ($ho,$timeoutref) = @_; # $ho might be a $gho > + my $nestinglvl = $ho->{NestingLevel} || $ho->{Host}{NestingLevel}; I think this wannts to be // not ||. If you agree I will fix this up and commit. Since what this does otherwise is to take all baremetal hosts and give them an empty Host hash due to autovivification. > + if ($nestinglvl) { > + $adjust->(1 << $nestinglvl, "nesting level"); > + } I still think the use of << is very odd and I can't resist moaning about it. But you're the patch author so I will let you choose the style here. Ian.