Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28259C77B72 for ; Mon, 17 Apr 2023 11:45:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F67485F72; Mon, 17 Apr 2023 13:45:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="il+JjbF9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3E8385F2D; Mon, 17 Apr 2023 13:45:13 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9197E85F74 for ; Mon, 17 Apr 2023 13:45:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBFFB617E0; Mon, 17 Apr 2023 11:45:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11001C4339B; Mon, 17 Apr 2023 11:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681731906; bh=twyjJhiQLg+80/MidOPkfnQ3gJVzGB5K4do6A60whvA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=il+JjbF9gBpt8VtfZ/yMBLyRLEUe1Cs2BKFxkt6SkhiT+QCcnU3l+Mne723bTMapW NbptrSF/4I6GG4d2iJIH7l/jntBotrbgGmyITAgODzCDR5MA+gN/8osMZgexUkB8/D XYMhRRms8dUOzWqXZoFDZfCHAWMu07eeT5u6lonGUwXq8JwsrPaFKwNXDp73o+FHr0 5v2s/nZPzUgek9F+Gcf+zFmQXN/dZntRc+QEpYUKzvDmvhgSO0Lx4dEqT4qvz5tUhl VtpUZYFI26VHwSVDlB2AMs+lGbzsbR1sialg12Wywbshty0YEh4/z1q59+CBf7eKHf vhCa2A/CZoSkw== Message-ID: <24573494-b8e6-7b66-8607-7bcadb5cf91e@kernel.org> Date: Mon, 17 Apr 2023 14:45:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 04/23] arm: dts: k3-am642-sk: Fix mmc1 pinmux pull polarity Content-Language: en-US To: Nishanth Menon Cc: Simon Glass , Vignesh Raghavendra , Tom Rini , Neil Armstrong , Anand Gadiyar , Georgi Vlaev , u-boot@lists.denx.de, Neha Malcom Francis , Nikhil M Jain References: <20230414075726.387461-1-nm@ti.com> <20230414075726.387461-5-nm@ti.com> <3bdf9e7a-85d3-9fab-c9a5-b6730f076285@kernel.org> <20230417111217.na3mqxd4xwwxm6ae@shimmer> From: Roger Quadros In-Reply-To: <20230417111217.na3mqxd4xwwxm6ae@shimmer> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 17/04/2023 14:12, Nishanth Menon wrote: > On 13:42-20230417, Roger Quadros wrote: >> >> >> On 14/04/2023 10:57, Nishanth Menon wrote: >>> Fix the pinmux pull polarity. >>> >>> This is a pending upstream kernel updates as of v6.3-rc6. >>> >>> Signed-off-by: Nishanth Menon >>> --- >>> Sent to kernel.org https://lore.kernel.org/linux-devicetree/20230414073328.381336-1-nm@ti.com/ >> >> Link to actual patch is >> https://lore.kernel.org/linux-devicetree/20230414073328.381336-3-nm@ti.com/ >> >>> >>> arch/arm/dts/k3-am642-sk.dts | 16 +++++++++------- >>> 1 file changed, 9 insertions(+), 7 deletions(-) >>> >>> diff --git a/arch/arm/dts/k3-am642-sk.dts b/arch/arm/dts/k3-am642-sk.dts >>> index 4fb279489cfc..cc2027417e86 100644 >>> --- a/arch/arm/dts/k3-am642-sk.dts >>> +++ b/arch/arm/dts/k3-am642-sk.dts >>> @@ -223,15 +223,17 @@ >>> >>> &main_pmx0 { >>> main_mmc1_pins_default: main-mmc1-pins-default { >>> + /* XXX: Kernel-Upstream: TODO: Upstream (pull changes) */ >> >> Do we really want to sprinkle these comments in u-boot upstream? > > I have no other means to indicate that these nodes need to get to > upstream kernel and when they do get into upstream kernel, what needs to > be dropped from u-boot. > > I am open to suggestions here. > >> If we are quite sure this makes to upstream kernel we might as well pull them into >> u-boot as is. > > No, that has been the reason why the entire dt mismatch occurred in the > first place. the subjective evaluation from various devs have been way > off. if it makes it to kernel.org master, only then can we claim that > the changes are in upstream. In that case we do not accept any DT patches in u-boot till at least Acked by kernel maintainer?