Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A813C47096 for ; Thu, 3 Jun 2021 16:20:34 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CBD2613D2 for ; Thu, 3 Jun 2021 16:20:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CBD2613D2 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.136507.253051 (Exim 4.92) (envelope-from ) id 1loq4x-0004iK-AX; Thu, 03 Jun 2021 16:20:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 136507.253051; Thu, 03 Jun 2021 16:20:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loq4x-0004iD-7Z; Thu, 03 Jun 2021 16:20:19 +0000 Received: by outflank-mailman (input) for mailman id 136507; Thu, 03 Jun 2021 16:20:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loq4w-0004i7-Ag for xen-devel@lists.xenproject.org; Thu, 03 Jun 2021 16:20:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loq4w-0001Us-29 for xen-devel@lists.xenproject.org; Thu, 03 Jun 2021 16:20:18 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1loq4w-0005es-0z for xen-devel@lists.xenproject.org; Thu, 03 Jun 2021 16:20:18 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1loq4s-0006Zd-L2; Thu, 03 Jun 2021 17:20:14 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=dj5r/43lJoGQdSDSc6b6HAMYHd+EFCRB/4PukVSBLZk=; b=eueJejZJQ/IJv00GxpXuhF11Yp paFHCJEduHEqyJm0Zan6G/xObj25QV59Hd8YwK82KIoPaDnUCSPugafcr8/eX0elcIeXwKT2WfEEx iygyEKYgQ7qNm9E97LEqusuqPtrzDD4pJ7+wpeD9js2Cee9306jwYc8SKrn1OH2tbmn8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24761.318.185554.93009@mariner.uk.xensource.com> Date: Thu, 3 Jun 2021 17:20:14 +0100 To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu Subject: [PATCH v4] tools/libs/store: cleanup libxenstore interface In-Reply-To: <20210512144832.19026-1-jgross@suse.com> References: <20210512144832.19026-1-jgross@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("[PATCH v4] tools/libs/store: cleanup libxenstore interface"): > There are some internals in the libxenstore interface which should be > removed. Thanks. And sorry for not reviewing this sooner. > Move those functions into xs_lib.c and the related definitions into > xs_lib.h. Remove the functions from the mapfile. Add xs_lib.o to > xenstore_client as some of the internal functions are needed there. > > Bump the libxenstore version to 4.0 as the change is incompatible. > Note that the removed functions should not result in any problem as > they ought to be used by xenstored or xenstore_client only. I am happy with the API and ABI changes. The situation with the expanding buffer functions (which I think is the only thing you are moving?) is unfortunate. We have some more of similar code in libxl. And probably elsewhere in the codebase. It would be nice to make them shared but I think that is a task for another day. The sanitise value functions should perhaps be exposed with more enssible names ? I think this was more difficult to review than it needed to be particularly because of the mixture of code motion with other changes. Anyway, thanks for cleaning this up. All evidence to the contrary, it *is* appreciated. Reviewed-by: Ian Jackson Regards, Ian.