From: "mrbff (Code Review)" Date: Tue, 21 Jan 2025 14:14:27 +0000 In-Reply-To: References: Reply-To: marco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <24b3257c027a8fcef95dce03cb335a728fb44f93-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="z0HHbeIDMMg="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stipa , plaisthos , flichtenheld , openvpn-devel --z0HHbeIDMMg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/809?usp=3Demail ) Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... Patch Set 11: (1 comment) File src/openvpn/route.h: http://gerrit.openvpn.net/c/openvpn/+/809/comment/7dd177d3_7d6de585 : PS11, Line 325: destroy_routes_v4(struct route_list *rl, const struct tunta= p *tt, > Apart from lacking comments, how does it differ from delete_routes()? Cou= ldn't we reuse existing fun [=E2=80=A6] The destroy_routes_vx are used to split the logic of delete_routes in v4 an= d v6 and also to delete the routes in the "options" struct. In most cases w= here delete_route functions are used it is correct not to delete the routes= in the "options" struct so I simply created the functions I needed. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 11 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Tue, 21 Jan 2025 14:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa Gerrit-MessageType: comment --z0HHbeIDMMg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/route.h:

    • Patch Set #11, Line 325: = destroy_routes_v4(struct ro= ute_list *rl, const struct tuntap *tt,

      Apart from lac= king comments, how does it differ from delete_routes()? Couldn't we reu= se existing fun [=E2=80=A6]

      The destroy_routes_vx are used to split the log= ic of delete_routes in v4 and v6 and also to delete the routes in the "= ;options" struct. In most cases where delete_route functions are used = it is correct not to delete the routes in the "options" struct so= I simply created the functions I needed.

To view= , visit c= hange 809. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I507180d7397b6959844a3090801= 0132bc3411067
Gerrit-Change-Number: 809
Gerrit-PatchSet: 11
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Tue, 21 Jan 2025 14:14:27= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
Gerrit-MessageType: comment
--z0HHbeIDMMg=--