From: "MaxF (Code Review)"
Date: Thu, 13 Jun 2024 15:43:07 +0000
In-Reply-To:
References:
Reply-To: max@...2606..., arne-openvpn@...1227...,
rein.vanbaaren@...1435..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <24b403f5e1c4855c9376ec7d887e6e169aea47b7-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="sUw+pFUCIZw="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Fix
MBEDTLS_DEPRECATED_REMOVED build errors
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: comododragon
Cc: flichtenheld , plaisthos , openvpn-devel
--sUw+pFUCIZw=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open=
vpn/+/681?usp=3Demail )
Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Generally looks sensible. [=E2=80=A6]
Splitting up these changes is difficult because the new mbedtls_ssl_protoco=
l_version enum doesn't contain values for TLS 1.0 or 1.1 in the first place.
Should we first make a commit to disable old TLS versions, and then a commi=
t to switch to the new functions?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/681?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9
Gerrit-Change-Number: 681
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: comododragon
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Thu, 13 Jun 2024 15:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--sUw+pFUCIZw=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">Patchset:
Splitting up these changes is difficult because the new mbe=
dtls_ssl_protocol_version enum doesn't contain values for TLS 1.0 or 1.=
1 in the first place.
Should we first make a commit to disable old TLS versions, and the=
n a commit to switch to the new functions?
To vie=
w, visit =
change 681. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If96c2ebd2af16b18ed34820e8c0=
531547e2076d9
Gerrit-Change-Number: 681
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: comododragon <rein.vanbaaren@...493...=
1435...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Thu, 13 Jun 2024 15:43:07=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--sUw+pFUCIZw=--