From: "stipa (Code Review)" Date: Thu, 1 May 2025 09:05:45 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <24e3a980f0c65cabd28a0dcaef0401ef4de7457f-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="IviM7//guRk="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: flichtenheld , plaisthos , openvpn-devel --IviM7//guRk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/904?usp=3Demail ) Change subject: dns: deal with --dhcp-options when --dns is active ...................................................................... Patch Set 15: Code-Review+1 (2 comments) Patchset: PS15: Stared at the code and slightly tested on Windows, both --dhcp-option dns a= nd --dns work, in various combinations. I haven't checked env variables and= non-Windows parts. While not the fault of this patch, I noticed that inside run_up_down_servic= e() we do not log success of setting DNS via service, like we normally do w= hen we talk to the service: 2025-05-01 11:49:09 us=3D187000 INET address service: add 10.8.0.2/24 2025-05-01 11:49:09 us=3D203000 IPv4 MTU set to 1500 on interface 20 usin= g service Let's do that for DNS, too, in a separate patch. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/904/comment/dbd3e34f_fbb036f8 : PS15, Line 4299: tuntap_options_postprocess_dns(o); Why WIN32 and Android require special treatment? I see that it was not adde= d in this patch, but still a comment "why" could be in place, since we touc= h this fragment. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a Gerrit-Change-Number: 904 Gerrit-PatchSet: 15 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: d12fk Gerrit-Comment-Date: Thu, 01 May 2025 09:05:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --IviM7//guRk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, flichtenheld, plaisthos. <= /p>

Patch set 15:Code-Review +1

V= iew Change

2 comments:

  • Patchset:

    • Patch Set #15:

      Stared at the code and slightly tested on W= indows, both --dhcp-option dns and --dns work, in various combinations. I h= aven't checked env variables and non-Windows parts.

      While not the fault of this patc= h, I noticed that inside run_up_down_service() we do not log success of set= ting DNS via service, like we normally do when we talk to the service:

      <= pre style=3D"font-family: monospace,monospace; white-space: pre-wrap;"> 20= 25-05-01 11:49:09 us=3D187000 INET address service: add 10.8.0.2/24
      20= 25-05-01 11:49:09 us=3D203000 IPv4 MTU set to 1500 on interface 20 using se= rvice

      Let's do that for DNS, too, in a separate patch.
  • File src/openvpn/optio= ns.c:

    • Patch Set #15= , Line 4299: tu= ntap_options_postprocess_dns(o);

      Why WIN32 and Android require special treatment?= I see that it was not added in this patch, but still a comment "why&q= uot; could be in place, since we touch this fragment.

  • To view, visit change 904. To unsubscribe, or for help writing mail filters= , visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb= 2e9cb2570cd6a
    Gerrit-Change-Number: 904
    Gerrit-PatchSet: 15
    Gerrit-Owner: d12fk <heiko@...515...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-Reviewer: stipa <lstipakov@...277...= >
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: d12fk <heiko@...515...>= ;
    Gerrit-Comment-Date: Thu, 01 May 2025 09:05:45= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --IviM7//guRk=--