From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR Date: Fri, 19 Oct 2018 13:42:41 -0700 Message-ID: <25246891.FZNb5hYFUk@dk-thinkpad-x260> References: <20181011004124.4110-1-jose.souza@intel.com> <20181011004124.4110-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2EAB6E54F for ; Fri, 19 Oct 2018 20:43:00 +0000 (UTC) In-Reply-To: <20181011004124.4110-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkbmVzZGF5LCBPY3RvYmVyIDEwLCAyMDE4IDU6NDE6MjAgUE0gUERUIEpvc8OpIFJvYmVy dG8gZGUgU291emEgd3JvdGU6Cj4gSXQgc2hvdWxkIGFsd2F5cyB3YWl0IGZvciBpZGxlIHN0YXRl IHdoZW4gZGlzYWJsaW5nIFBTUiBiZWNhdXNlIFBTUgo+IGNvdWxkIGJlIGluYWN0aXZlIGR1ZSBh IGNhbGwgdG8gaW50ZWxfcHNyX2V4aXQoKSBhbmQgd2hpbGUgUFNSIGlzCj4gc3RpbGwgYmVpbmcg ZGlzYWJsZWQgYXN5bmNocm9ub3VzbHkgdXNlcnNwYWNlIGNvdWxkIGNoYW5nZSB0aGUKPiBtb2Rl c2V0IGNhdXNpbmcgYSBjYWxsIHRvIHBzcl9kaXNhYmxlKCkgdGhhdCB3aWxsIG5vdCB3YWl0IGZv ciBQU1IKPiBpZGxlIGFuZCB0aGVuIFBTUiB3aWxsIGJlIGVuYWJsZWQgYWdhaW4gd2hpbGUgUFNS IGlzIHN0aWxsIG5vdCBpZGxlLgo+IAo+IHYyOiByZWJhc2VkIG9uIHRvcCBvZiB0aGUgcGF0Y2gg cmV1c2luZyBwc3JfZXhpdCgpCj4gCj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu dGVsLmNvbT4KPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBp bnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5z b3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5j IHwgNDEgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDE4IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcHNyLmMgaW5kZXggZjY5OGIzZjQ1YzZkLi4xNmQwZTNkZjdkZTAgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wc3IuYwo+IEBAIC02NjEsOCArNjYxLDEyIEBAIHN0YXRpYyB2b2lkIGludGVs X3Bzcl9leGl0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gKmRldl9wcml2KSB7Cj4gIAl1MzIg dmFsOwo+IAo+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLmFjdGl2ZSkKPiArCWlmICghZGV2X3ByaXYt PnBzci5hY3RpdmUpIHsKPiArCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ICsJCQlX QVJOX09OKEk5MTVfUkVBRChFRFBfUFNSMl9DVEwpICYgRURQX1BTUjJfRU5BQkxFKTsKPiArCQlX QVJOX09OKEk5MTVfUkVBRChFRFBfUFNSX0NUTCkgJiBFRFBfUFNSX0VOQUJMRSk7CgpEbyB3ZSBy ZWFsbHkgbmVlZCBzbyBtYW55IFdBUk5fT05zIG5lZWRpbmcgTU1JTyByZWFkcz8gVGhlcmUgYXJl IGFsbW9zdCBhcyAKbWFueSBsaW5lcyBvZiB3YXJuaW5ncyBhcyBjb2RlIGluIHRoaXMgZnVuY3Rp b24uIEkgdGhpbmsgYXQgdGhpcyBwb2ludCwgd2UgCmtub3cgdGhpcyBjb2RlIHdvcmtzIGFuZCB0 aGUgd2FybmluZ3MgaW4gcHNyX2V4aXQoKSBzaG91bGQgYmUgcmVtb3ZlZC4KCj4gIAkJcmV0dXJu Owo+ICsJfQo+IAo+ICAJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gIAkJdmFs ID0gSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCk7Cj4gQEAgLTY4MCwzMiArNjg0LDIzIEBAIHN0YXRp YyB2b2lkCj4gIGludGVsX3Bzcl9kaXNhYmxlX3NvdXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19p OTE1KGludGVsX2RwKTsKPiArCWk5MTVfcmVnX3QgcHNyX3N0YXR1czsKPiArCXUzMiBwc3Jfc3Rh dHVzX21hc2s7Cj4gCj4gLQlpZiAoZGV2X3ByaXYtPnBzci5hY3RpdmUpIHsKPiAtCQlpOTE1X3Jl Z190IHBzcl9zdGF0dXM7Cj4gLQkJdTMyIHBzcl9zdGF0dXNfbWFzazsKPiAtCj4gLQkJaW50ZWxf cHNyX2V4aXQoZGV2X3ByaXYpOwo+ICsJaW50ZWxfcHNyX2V4aXQoZGV2X3ByaXYpOwo+IAo+IC0J CWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkgewo+IC0JCQlwc3Jfc3RhdHVzID0gRURQ X1BTUjJfU1RBVFVTOwo+IC0JCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSMl9TVEFUVVNfU1RB VEVfTUFTSzsKPiAtCQl9IGVsc2Ugewo+IC0JCQlwc3Jfc3RhdHVzID0gRURQX1BTUl9TVEFUVVM7 Cj4gLQkJCXBzcl9zdGF0dXNfbWFzayA9IEVEUF9QU1JfU1RBVFVTX1NUQVRFX01BU0s7Cj4gLQkJ fQo+IC0KPiAtCQkvKiBXYWl0IHRpbGwgUFNSIGlzIGlkbGUgKi8KPiAtCQlpZiAoaW50ZWxfd2Fp dF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gLQkJCQkJICAgIHBzcl9zdGF0dXMsIHBzcl9zdGF0 dXNfbWFzaywgMCwKPiAtCQkJCQkgICAgMjAwMCkpCj4gLQkJCURSTV9FUlJPUigiVGltZWQgb3V0 IHdhaXRpbmcgZm9yIFBTUiBJZGxlIFN0YXRlXG4iKTsKPiArCWlmIChkZXZfcHJpdi0+cHNyLnBz cjJfZW5hYmxlZCkgewo+ICsJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVM7Cj4gKwkJcHNy X3N0YXR1c19tYXNrID0gRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gIAl9IGVsc2Ugewo+ IC0JCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkKPiAtCQkJV0FSTl9PTihJOTE1X1JF QUQoRURQX1BTUjJfQ1RMKSAmIEVEUF9QU1IyX0VOQUJMRSk7Cj4gLQkJZWxzZQo+IC0JCQlXQVJO X09OKEk5MTVfUkVBRChFRFBfUFNSX0NUTCkgJiBFRFBfUFNSX0VOQUJMRSk7Cj4gKwkJcHNyX3N0 YXR1cyA9IEVEUF9QU1JfU1RBVFVTOwo+ICsJCXBzcl9zdGF0dXNfbWFzayA9IEVEUF9QU1JfU1RB VFVTX1NUQVRFX01BU0s7Cj4gIAl9Cj4gKwo+ICsJLyogV2FpdCB0aWxsIFBTUiBpcyBpZGxlICov Cj4gKwlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIHBzcl9zdGF0dXMsIHBz cl9zdGF0dXNfbWFzaywgMCwKPiArCQkJCSAgICAyMDAwKSkKPiArCQlEUk1fRVJST1IoIlRpbWVk IG91dCB3YWl0aW5nIGZvciBQU1IgSWRsZSBTdGF0ZVxuIik7Cj4gIH0KPiAKPiAgc3RhdGljIHZv aWQgaW50ZWxfcHNyX2Rpc2FibGVfbG9ja2VkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCgoK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK